feat: update stable swap impl#46
Open
ChefMist wants to merge 16 commits into
Open
Conversation
ChefMist
commented
Jun 4, 2025
ChefMist
commented
Jun 4, 2025
| assertEq(ERC20(address(BUSD)).balanceOf(FROM), 100000999768181033551138); // roughly 0.999768181 recieved from swap | ||
| } | ||
|
|
||
| function test_stableSwap_ExactInput0For1_SamePath_FromRouter() public { |
Contributor
Author
There was a problem hiding this comment.
this is the critical test to ensure it passes
ChefMist
commented
Jun 4, 2025
|
|
||
| // Update amountIn for the next hop. this is done as swapContract do not return the output amount | ||
| // If this is the last hop, amountIn is the output amount | ||
| amountIn = ERC20(output).balanceOf(address(this)) - outputTokenBal; |
Contributor
Author
There was a problem hiding this comment.
unchecked removed as a safeguard due to this minus operation
chefrabbid
approved these changes
Jun 4, 2025
Contributor
Author
|
will deploy under this deploymentSalt()
|
ChefSnoopy
approved these changes
Jun 4, 2025
jpopxfile
approved these changes
Jun 4, 2025
Contributor
Author
|
will only merge once QA is done with this new version on FE -- address is |
Contributor
Author
|
Status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR update stableSwap router
Previously
amountInThis PR update it to respect
amountIn-- unfortunately have to tweak optimizer run to be within size limit