Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1090 Fix comment commands not checking out the correct branch #1094

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

loicdiridollou
Copy link
Contributor

Issue came from the fact that the checkout was only pulling main and not the branch on which the PR was at, this PR fixes that by retrieving the correct branch name and passing it to the checkout github action to pull the correct branch and not main (which is the default).

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loicdiridollou . I'm assuming you've tested this!

@Dr-Irv Dr-Irv merged commit 3547cda into pandas-dev:main Jan 13, 2025
10 checks passed
@loicdiridollou loicdiridollou deleted the gh1090_fix_comment_cmds branch March 9, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands to trigger optional tests are checking out main and not current branch
2 participants