Backport PR #48943 on branch 1.5.x (REGR: ExcelWriter.book not settable) #48959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumberbot-app
bot
added
Bug
Deprecate
|
cc @rhshadrach could you have a look? The typing failure looks legit |
|
This PR got checked with mypy 0.971; the main PR got checked with 0.981. Locally, I'm seeing the same - mypy flags this as an issue with 0.971 but not 0.981. I get the same behavior with the OP code from this issue back from 2017: python/mypy#4165. Since 1.5.x is pinned with mypy 0.971, I'm thinking we add a |
|
Yep makes sense, thx for investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #48943: REGR: ExcelWriter.book not settable