Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement String Accumulations with nanoarrow #60667

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -54,7 +54,7 @@ jobs:
command: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.2.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.14.0 meson[ninja]==1.2.1
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytest>=7.3.2 pytest-xdist>=3.4.0 hypothesis>=6.84.0
python -m pip install --no-cache-dir --no-build-isolation -e . -Csetup-args="--werror"
python -m pip list --no-cache-dir
8 changes: 4 additions & 4 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -233,7 +233,7 @@ jobs:
run: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.3.2 meson-python==0.14.0
python -m pip install numpy -Csetup-args="-Dallow-noblas=true"
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytest>=7.3.2 pytest-xdist>=3.4.0 hypothesis>=6.84.0
python -m pip install --no-cache-dir --no-build-isolation -e . -Csetup-args="--werror"
@@ -272,7 +272,7 @@ jobs:
run: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.2.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.14.0 meson[ninja]==1.3.2
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytest>=7.3.2 pytest-xdist>=3.4.0 hypothesis>=6.84.0
python -m pip install --no-cache-dir --no-build-isolation -e . -Csetup-args="--werror"
python -m pip list --no-cache-dir
@@ -344,7 +344,7 @@ jobs:
- name: Build Environment
run: |
python --version
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.3.2 meson-python==0.14.0
python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
python -m pip install versioneer[toml]
python -m pip install python-dateutil tzdata cython hypothesis>=6.84.0 pytest>=7.3.2 pytest-xdist>=3.4.0 pytest-cov
@@ -389,7 +389,7 @@ jobs:
# Tests segfault with numpy 2.2.0: https://github.com/numpy/numpy/pull/27955
run: |
python --version
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.3.2 meson-python==0.14.0
python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple cython numpy
python -m pip install versioneer[toml]
python -m pip install python-dateutil pytz tzdata hypothesis>=6.84.0 pytest>=7.3.2 pytest-xdist>=3.4.0 pytest-cov
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -137,3 +137,9 @@ doc/source/savefig/
# Interactive terminal generated files #
########################################
.jupyterlite.doit.db

# meson subproject files #
##########################
subprojects/*
!subprojects/packagefiles
!subprojects/*.wrap
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -98,7 +98,7 @@ repos:
rev: v19.1.6
hooks:
- id: clang-format
files: ^pandas/_libs/src|^pandas/_libs/include
files: ^pandas/_libs|pandas/_libs/src|^pandas/_libs/include
args: [-i]
types_or: [c, c++]
- repo: local
4 changes: 2 additions & 2 deletions ci/deps/actions-310-minimum_versions.yaml
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-310.yaml
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-311-downstream_compat.yaml
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-311-numpydev.yaml
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@ dependencies:

# build dependencies
- versioneer
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0
- cython>=0.29.33

# test dependencies
4 changes: 2 additions & 2 deletions ci/deps/actions-311-pyarrownightly.yaml
Original file line number Diff line number Diff line change
@@ -6,9 +6,9 @@ dependencies:

# build dependencies
- versioneer
- meson=1.2.1
- meson=1.3.2
- cython>=0.29.33
- meson-python=0.13.1
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-311.yaml
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-312.yaml
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/actions-pypy-39.yaml
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions ci/deps/circle-311-arm64.yaml
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ dependencies:
# build dependencies
- versioneer
- cython>=0.29.33
- meson=1.2.1
- meson-python=0.13.1
- meson=1.3.2
- meson-python=0.14.0

# test dependencies
- pytest>=7.3.2
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@ dependencies:
# build dependencies
- versioneer
- cython~=3.0.5
- meson=1.2.1
- meson-python=0.13.1
- meson>=1.3.0
- meson-python>=0.14.0

# test dependencies
- pytest>=7.3.2
6 changes: 5 additions & 1 deletion meson.build
Original file line number Diff line number Diff line change
@@ -4,11 +4,15 @@ project(
'c', 'cpp', 'cython',
version: run_command(['generate_version.py', '--print'], check: true).stdout().strip(),
license: 'BSD-3',
meson_version: '>=1.2.1',
meson_version: '>=1.3.0',
default_options: [
'buildtype=release',
'c_std=c11',
'cpp_std=c++17',
'warning_level=2',
'default_library=static',
# TODO: how can we only set this for nanobind?
'cpp_args=-Wno-sign-compare'
]
)

Loading