Skip to content

Conversation

Anurag-Varma
Copy link
Contributor

@Anurag-Varma Anurag-Varma commented Feb 16, 2025

@Anurag-Varma Anurag-Varma changed the title Bug#60695 Bug: Fix MultiIndex from_tuples causing wrong output with input of type tuples having NaN values Feb 16, 2025
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Anurag-Varma Anurag-Varma marked this pull request as ready for review February 24, 2025 01:01
@rhshadrach
Copy link
Member

@Anurag-Varma - I think this looks good, just need to resolve the conflict by merging main.

@Anurag-Varma
Copy link
Contributor Author

@Anurag-Varma - I think this looks good, just need to resolve the conflict by merging main.

Thanks @rhshadrach I fixed the changes which you have mentioned in the review and sent the new commit

@Anurag-Varma Anurag-Varma requested a review from rhshadrach March 6, 2025 01:34
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach changed the title Bug: Fix MultiIndex from_tuples causing wrong output with input of type tuples having NaN values Bug: Fix MultiIndex from_tuples on tuples with NaNs Mar 7, 2025
@rhshadrach rhshadrach changed the title Bug: Fix MultiIndex from_tuples on tuples with NaNs BUG: Fix MultiIndex from_tuples on tuples with NaNs Mar 7, 2025
@rhshadrach rhshadrach merged commit f1b00b8 into pandas-dev:main Mar 7, 2025
42 checks passed
@rhshadrach
Copy link
Member

Thanks @Anurag-Varma!

gm-oo9 pushed a commit to gm-oo9/pandas that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants