-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Fix Index.equals between object and string #61541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanggon6107
wants to merge
9
commits into
pandas-dev:main
Choose a base branch
from
sanggon6107:fix-idx-comp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−16
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2d8b55e
Fix Index.equal
sanggon6107 509c74c
Fix test_mixed_col_index_dtype
sanggon6107 2902e07
Merge branch 'main' into fix-idx-comp
sanggon6107 0ed742d
Fix test_mixed_col_index_dtype
sanggon6107 c79df80
Fix parametrize for tests
sanggon6107 bce1489
Merge branch 'main' into fix-idx-comp
sanggon6107 e181dac
Merge branch 'main' into fix-idx-comp
sanggon6107 5ac2681
Add whatsnew
sanggon6107 0490dee
Merge branch 'main' into fix-idx-comp
sanggon6107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ | |
ensure_index, | ||
ensure_index_from_sequences, | ||
) | ||
from pandas.testing import assert_series_equal | ||
|
||
|
||
class TestIndex: | ||
|
@@ -1717,3 +1718,51 @@ def test_is_monotonic_pyarrow_list_type(): | |
idx = Index([[1], [2, 3]], dtype=pd.ArrowDtype(pa.list_(pa.int64()))) | ||
assert not idx.is_monotonic_increasing | ||
assert not idx.is_monotonic_decreasing | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"dtype", | ||
[ | ||
"string[python]", | ||
pytest.param( | ||
"string[pyarrow]", | ||
marks=td.skip_if_no("pyarrow"), | ||
), | ||
pytest.param( | ||
"str", | ||
marks=td.skip_if_no("pyarrow"), | ||
), | ||
], | ||
) | ||
def test_index_equals_different_string_dtype(dtype): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you instead use the fixture |
||
# GH 61099 | ||
idx_obj = Index(["a", "b", "c"]) | ||
idx_str = Index(["a", "b", "c"], dtype=dtype) | ||
|
||
assert idx_obj.equals(idx_str) | ||
assert idx_str.equals(idx_obj) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"dtype", | ||
[ | ||
"string[python]", | ||
pytest.param( | ||
"string[pyarrow]", | ||
marks=td.skip_if_no("pyarrow"), | ||
), | ||
pytest.param( | ||
"str", | ||
marks=td.skip_if_no("pyarrow"), | ||
), | ||
], | ||
) | ||
def test_index_comparison_different_string_dtype(dtype): | ||
# GH 61099 | ||
idx = Index(["a", "b", "c"]) | ||
s_obj = Series([1, 2, 3], index=idx) | ||
s_str = Series([4, 5, 6], index=idx.astype(dtype)) | ||
|
||
expected = Series([True, True, True], index=["a", "b", "c"]) | ||
result = s_obj < s_str | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you also check |
||
assert_series_equal(result, expected) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition was added in #56106, I think the
na_value
part was added just to be conservative.