BUG: Fix ExtensionArray binary op protocol #61990
Merged
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd tests for numeric EA shape errors
tisjayy
force-pushed
the
fix-ea-non-1d-ops
branch
from
f9cb022 to
9496569
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
tisjayy
changed the title
for more information, see https://pre-commit.ci
tisjayy
changed the title
arthurlw
reviewed
Jul 30, 2025
mroeschke
added
Numeric Operations
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
|
@jbrockmendel can you please review at your convenience? thanks! |
|
I'm out of town for a few days, will look at this when i get back. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@jbrockmendel changes you requested have been made. please take a look |
|
Hi @mroeschke , I think this pr is ready, would you mind reviewing it if you get a chance? |
jbrockmendel
approved these changes
Aug 14, 2025
|
thanks @tisjayy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.