Using Edit Distance to Word-Diff Across Multiple Lines #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
reviewed
Aug 22, 2024
lib/WordDiff.ml
Outdated
| construct_pairs [] ys lcs ((None, Some y) :: acc) | ||
| | x :: xs, y :: ys, [] -> | ||
| construct_diff xs ys [] (Changed x :: acc_mine) (Changed y :: acc_their) | ||
| construct_pairs xs ys [] ((Some x, Some y) :: acc) |
Collaborator
Author
There was a problem hiding this comment.
Hi, do you mind elaborating more on why it is wrong?
Owner
There was a problem hiding this comment.
Try it on the following test!
- aaaaaaaaa a
- egdg xsd fi sdgfyu s gd csue c e yeg scy
+ aaaaaaaaa b
+ yugyu fft yu utf ytfutf uyg gygu yftuf gg uf ft
Collaborator
Author
There was a problem hiding this comment.
LACS -> A sequence of lines
Here, we have two lines in 1 and two lines in 2.
So LCAS is a matter of lines. Here, it will be a length of 1, and the LCAS are (Some aaaaaaaaa a, Some aaaaaaaaa b)
So here, in the accumulator, I am adding x and y as being paired, when x and y are not part of the LACS.
Here, the example, x and y corresponds to egdg ... and yugyu ...
So they should not be paired.
- Fixed bugs in the pairing of lines
The LACS must consist of the _two_ subsequence
- Finished rendering paired lines
Co-authored-by: Alan Matthew <[email protected]>
panglesd
force-pushed
the
word-diffing-multiple-lines
branch
from
6424540 to
a978092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.