Resolve PHP 8.1 warning for rtrim() in functions.php #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I opened this PR thinking this was an issue "out of the box" with the Composer managed WP template; now I'm thinking this is might be something specific to my theme (which I assumed was the case at first but later dismissed in error). Leaving this open in case it's still useful, but my assumption that everyone else using php 8.3 would constantly see this warning too is probably not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of rtrim() deprecation that was logged for each page load in my local dev environment.
The issue was that trailingslashit() was sometimes getting a null value from parse_url(), which throwa a warning in php 8.1.
Updated line uses ?? operator so it always passes a string instead of null.