feat(trie): add sparse trie Display impl #14544
Conversation
Rjected
added
C-enhancement
Rjected
force-pushed
the
dan/add-display-impl-sparse-trie
branch
2 times, most recently
from
2f3046f to
ccee058
Compare
crates/trie/sparse/src/trie.rs
Outdated
| /// Turns a [`Nibbles`] into a [`String`] by converting each nibble to its hex representation. | ||
| fn encode_nibbles(nibbles: &Nibbles) -> String { | ||
| let mut output = String::with_capacity(nibbles.len().div_ceil(2)); | ||
| for nibble in nibbles.as_slice() { | ||
| let hex = format!("{nibble:01x}"); | ||
| output.push_str(&hex); | ||
| } | ||
| output | ||
| } |
There was a problem hiding this comment.
hmm won't this be confusing because 10 can be interpreted as both 0100 and a
maybe just do hex::encode(nibbles.pack())?
There was a problem hiding this comment.
doing hex::encode(nibbles.pack()) incorrectly encodes paths with odd length (we get an extra 0 at the end). I'm also expecting paths to be interpreted as hex, so I'm not sure why 10 should be interpreted as a?
There was a problem hiding this comment.
just pop the char at the end if len % 2 != 0, idk what you mean with the second sentence
Rjected
force-pushed
the
dan/add-display-impl-sparse-trie
branch
2 times, most recently
from
fcc5538 to
f1b5b28
Compare
crates/trie/sparse/src/trie.rs
Outdated
| let mut output = String::with_capacity(nibbles.len().div_ceil(2)); | ||
| for nibble in nibbles.as_slice() { | ||
| let hex = format!("{nibble:01x}"); | ||
| output.push_str(&hex); |
There was a problem hiding this comment.
push(char::from_digit(*nibble as u32, 16).unwrap())
crates/trie/sparse/src/trie.rs
Outdated
| /// Turns a [`Nibbles`] into a [`String`] by converting each nibble to its hex representation. | ||
| fn encode_nibbles(nibbles: &Nibbles) -> String { | ||
| let mut output = String::with_capacity(nibbles.len().div_ceil(2)); | ||
| for nibble in nibbles.as_slice() { | ||
| let hex = format!("{nibble:01x}"); | ||
| output.push_str(&hex); | ||
| } | ||
| output | ||
| } |
There was a problem hiding this comment.
just pop the char at the end if len % 2 != 0, idk what you mean with the second sentence
Co-authored-by: DaniPopes <[email protected]>
Rjected
force-pushed
the
dan/add-display-impl-sparse-trie
branch
from
757b772 to
be68954
Compare
Adds a display impl and tests it, uses indents by level when printing alternate form