Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): yield from sparse trie task #14556

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Feb 18, 2025

Description

Sparse trie task is a long running task on rayon thread pool. It blocks on each iteration attempting to receive sparse trie updates from the main task.

Yield from sparse trie task if there is no work to be done.

@rkrasiuk rkrasiuk marked this pull request as draft February 18, 2025 09:47
@rkrasiuk rkrasiuk marked this pull request as ready for review February 18, 2025 13:14
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this workaround should work

Sparse trie task is a long running task on rayon thread pool

this should not be the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants