Skip to content

feat(net): correct per-response size metric to avoid capacity/empty-block inflation #18553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(net): correct per-response size metric to avoid capacity/empty-block inflation #18553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22fac3a
feat(net): correct per-response size metric to avoid capacity/empty-b…
phrwlk Sep 18, 2025
d5667aa
Update request.rs
phrwlk Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions crates/net/downloaders/src/bodies/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use reth_network_peers::{PeerId, WithPeerId};
use reth_primitives_traits::{Block, GotExpected, InMemorySize, SealedBlock, SealedHeader};
use std::{
collections::VecDeque,
mem,
pin::Pin,
sync::Arc,
task::{ready, Context, Poll},
Expand Down Expand Up @@ -166,20 +165,17 @@ where
where
C::Body: InMemorySize,
{
let bodies_capacity = bodies.capacity();
let bodies_len = bodies.len();
let mut bodies = bodies.into_iter().peekable();

let mut total_size = bodies_capacity * mem::size_of::<C::Body>();
let mut total_size = 0;
while bodies.peek().is_some() {
let next_header = match self.pending_headers.pop_front() {
Some(header) => header,
None => return Ok(()), // no more headers
};

if next_header.is_empty() {
// increment empty block body metric
total_size += mem::size_of::<C::Body>();
self.buffer.push(BlockResponse::Empty(next_header));
} else {
let next_body = bodies.next().unwrap();
Expand Down