fix(rpc/simulate): block number/timestamp not checked #18554
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetkeyboard
requested review from
mattsse,
Rjected and
RomanHodulak
as code owners
mattsse
requested changes
Sep 19, 2025
Comment on lines
43
to
47
| /// Block number in sequence did not increase. | ||
| #[error("Block number in sequence did not increase")] | ||
| BlockNumberNotIncreased, | ||
| /// Block timestamp in sequence did not increase or stay the same. | ||
| #[error("Block timestamp in sequence did not increase or stay the same")] |
There was a problem hiding this comment.
can we double check the error message for this with geth's impl
ideally we mirror what is already used there
There was a problem hiding this comment.
updated, pls review again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of
eth_simulateV1not check the block number and timestamp issue.when calling with the below request:
{ "jsonrpc": "2.0", "id": 1, "method": "eth_simulateV1", "params": [ { "blockStateCalls": [ { "blockOverrides": { "number": "0x91" }, "calls": [ { "from": "0xc100000000000000000000000000000000000000", "input": "0x4360005260206000f3" } ] }, { "blockOverrides": { "number": "0x87" }, "calls": [ { "from": "0xc000000000000000000000000000000000000000", "input": "0x4360005260206000f3" } ] } ] }, "latest" ] }geth return as error:
{ "jsonrpc": "2.0", "id": 1, "error": { "code": -38020, "message": "block numbers must be in order: 145 \u003c= 23387288" } }but reth can successfully execute it:
{ "jsonrpc": "2.0", "id": 1, "result": [ { "hash": "0xd9da862edeb8c90afd4f068fdec3392fe7e460b7855d4332991ae6246c6d7350", "parentHash": "0x176348bef02508d7698cf5b39cd622a7ea277a4c25d536a2e6c13da10713ad5a", "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347", "miner": "0x4838b106fce9647bdf1e7877bf73ce8b0bad5f97", "stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000", "transactionsRoot": "0x487480d708e5c17783485da0f128962ea9971acddf216b568b09ba669d15c64b", "receiptsRoot": "0x272f9721d2518637583443bb497e8fd6399c10a298960c41f6f17d2c2b3a2aa2", "logsBloom": "...", "difficulty": "0x0", "number": "0x91", "gasLimit": "0x2adf998", "gasUsed": "0xe893", "timestamp": "0x68cb7cf3", "extraData": "0x726574682f76312e372e302f6c696e7578", "mixHash": "0xead56a0a19ca30870185899b4dd368284558283f446b1e1dc9f33a898ae0986b", "nonce": "0x0000000000000000", "baseFeePerGas": "0x0", "withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "blobGasUsed": "0x0", "excessBlobGas": "0x100000", "parentBeaconBlockRoot": "0x0000000000000000000000000000000000000000000000000000000000000000", "requestsHash": "0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "size": "0x297", "uncles": [], "transactions": [ "0xbf3a17737bd18fa1fcb7cb6b3b074b8fc67e0468ad1cbc47f793cf3fe6dddf1e" ], "withdrawals": [], "calls": [ { "returnData": "0x0000000000000000000000000000000000000000000000000000000000000091", "logs": [], "gasUsed": "0xe893", "status": "0x1" } ] }, { "hash": "0x63a8f159c8c89b2f795889dc85699c47cfda282e194027b5eeac069b630939d9", "parentHash": "0xd9da862edeb8c90afd4f068fdec3392fe7e460b7855d4332991ae6246c6d7350", "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347", "miner": "0x4838b106fce9647bdf1e7877bf73ce8b0bad5f97", "stateRoot": "0x0000000000000000000000000000000000000000000000000000000000000000", "transactionsRoot": "0x487480d708e5c17783485da0f128962ea9971acddf216b568b09ba669d15c64b", "receiptsRoot": "0x272f9721d2518637583443bb497e8fd6399c10a298960c41f6f17d2c2b3a2aa2", "logsBloom": "...", "difficulty": "0x0", "number": "0x87", "gasLimit": "0x2adf998", "gasUsed": "0xe893", "timestamp": "0x68cb7cff", "extraData": "0x726574682f76312e372e302f6c696e7578", "mixHash": "0xb5b39f9be6df53d0bd21d7dc05ec275027017b13c92ed41f2b3152ef790ee5c0", "nonce": "0x0000000000000000", "baseFeePerGas": "0x0", "withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "blobGasUsed": "0x0", "excessBlobGas": "0x40000", "parentBeaconBlockRoot": "0x0000000000000000000000000000000000000000000000000000000000000000", "requestsHash": "0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "size": "0x297", "uncles": [], "transactions": [ "0xbf3a17737bd18fa1fcb7cb6b3b074b8fc67e0468ad1cbc47f793cf3fe6dddf1e" ], "withdrawals": [], "calls": [ { "returnData": "0x0000000000000000000000000000000000000000000000000000000000000087", "logs": [], "gasUsed": "0xe893", "status": "0x1" } ] } ] }