Skip to content

Persist static file CLI config#24823

Open
decofe wants to merge 1 commit into
mainfrom
centaur/1780503111-12078-17193
Open

Persist static file CLI config#24823
decofe wants to merge 1 commit into
mainfrom
centaur/1780503111-12078-17193

Conversation

@decofe

@decofe decofe commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • persist static file CLI overrides into reth.toml during node config loading
  • keep CLI values taking precedence over TOML values before building the static file provider
  • add a regression test for saving static-files.blocks-per-file.headers

Testing

  • cargo test -p reth-node-builder launch::common::tests::test_save_static_files_config
  • cargo fmt --check reports pre-existing repo-wide stable-rustfmt diffs unrelated to this patch

Prompted by: @joshieDo

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • bench: Adding new benchmarks or modifying existing benchmarks
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR
  • deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants