perf: truncate to i64 before jumping to dynamic jump table#317
Open
perf: truncate to i64 before jumping to dynamic jump table#317
Conversation
Truncate the i256 jump target to i64 at each dynamic jump site instead of doing a saturating convert in the dynamic jump table block. This removes the zext+icmp+select overhead from the jump table phi node, simplifying codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the saturating i256-to-i64 conversion from the dynamic jump table block to each dynamic jump site. This makes the phi node i64 instead of i256, simplifying the jump table codegen while preserving correctness (values that don't fit in i64 are mapped to
u64::MAX, which won't match any valid PC).