Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pack pragma for struct padding back #245

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

jrozner
Copy link
Contributor

@jrozner jrozner commented Jan 28, 2025

No description provided.

@jrozner jrozner marked this pull request as draft January 28, 2025 18:11
@jrozner jrozner mentioned this pull request Jan 28, 2025
@jrozner jrozner force-pushed the bugfix/windows-bitshift branch from 3fbea87 to 5abd1a6 Compare February 4, 2025 20:46
@jrozner jrozner marked this pull request as ready for review February 4, 2025 20:52
@hug-dev hug-dev linked an issue Feb 5, 2025 that may be closed by this pull request
hug-dev
hug-dev previously approved these changes Feb 5, 2025
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice result of the investigation, thanks for pushing it to the last mile!! Funny that the files are now smaller too!

Just one small comment for history purposes!

Signed-off-by: Joe Rozner <[email protected]>
@hug-dev hug-dev requested a review from wiktor-k February 6, 2025 08:34
@hug-dev hug-dev enabled auto-merge February 6, 2025 08:34
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Let's get this merged 🚀 Thanks!

@hug-dev hug-dev merged commit 0e1bdb7 into parallaxsecond:main Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status access violation
3 participants