Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows don't scroll the whole way to the bottom #290

Closed
mpelley opened this issue Jul 12, 2023 · 2 comments · Fixed by #296
Closed

Windows don't scroll the whole way to the bottom #290

mpelley opened this issue Jul 12, 2023 · 2 comments · Fixed by #296
Assignees

Comments

@mpelley
Copy link

mpelley commented Jul 12, 2023

The bottom part of a window is cut off when the contents are large enough so that it needs to be vertically scrolled. The attached screenshot is scrolled the whole way to the bottom. Notice also the down arrow of the scroll bar is missing.
image

@lyonsil lyonsil added this to Paranext Jul 12, 2023
@lyonsil lyonsil moved this to 📋Product Backlog in Paranext Jul 12, 2023
@FoolRunning
Copy link
Contributor

From looking into this a little bit, it looks like the new header pushed down the dock area without shrinking it vertically.
See height: calc(100% - 8px); in the definition for the .dock-layout style.

Note that the correct fix is not to change that to height: calc(100% - 56px); 😉

@irahopkinson irahopkinson self-assigned this Jul 16, 2023
@irahopkinson irahopkinson moved this from 📋Product Backlog to 🏗 In progress in Paranext Jul 16, 2023
@irahopkinson irahopkinson moved this from 🏗 In progress to 👀 In review in Paranext Jul 16, 2023
@irahopkinson irahopkinson linked a pull request Jul 16, 2023 that will close this issue
@irahopkinson
Copy link
Contributor

irahopkinson commented Jul 16, 2023

I put in a PR for this since it is a potential prerequisite to #66.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants