Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dock height #296

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix dock height #296

merged 1 commit into from
Jul 17, 2023

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Jul 16, 2023

  • also move toolbar to app component

This change is Reviewable

- also move toolbar to app component
@irahopkinson irahopkinson enabled auto-merge (squash) July 16, 2023 22:27
@irahopkinson irahopkinson linked an issue Jul 16, 2023 that may be closed by this pull request
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@irahopkinson irahopkinson merged commit 587939d into main Jul 17, 2023
@irahopkinson irahopkinson deleted the 290-fix-dock-height branch July 17, 2023 13:19
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some strange behavior when I drag a window around. It seems the window's width is dynamic, so it increases and shows a scroll bar when your dragged window is farther right than the screen:
image.png

I believe I set the styles up the way they were for the dock layout because that was the recommendation from rc-dock if I remember correctly. Or something similar to it at least. But I will say it is working better than I expected! Hopefully we can get things fixed with just a bit more tweaking.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@irahopkinson
Copy link
Contributor Author

I went back to the commit on main before this one and that behaviour is happening there already so it's not as a result of this change. I can't say I'd noticed this before but now that you have pointed it out it's hard to not notice.

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Sorry I assumed. I should have checked.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

tombogle added a commit that referenced this pull request Jul 19, 2023
With these changes, the menu no longer appears in Platform.Bible app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows don't scroll the whole way to the bottom
3 participants