pkg: Use new grpc.NewClient over grpc.Dial (#4676)

* pkg: Use newer grpc.NewClient over deprecated grpc.Dial

* Update deprecated golanglint-ci config

.golangci.yml

@@ -34,7 +34,9 @@ linters-settings:
           - pkg: github.com/segmentio/parquet-go
             desc: Use github.com/parquet-go/parquet-go instead
   errcheck:
-    exclude: ./.errcheck_excludes.txt
+    exclude-functions:
+      - (github.com/go-kit/log.Logger).Log
+      - (hash.Hash).Write
   goimports:
     local-prefixes: github.com/parca-dev/parca
   gofumpt:

pkg/debuginfo/store_test.go

@@ -109,7 +109,7 @@ func TestStore(t *testing.T) {
 		}
 	}()
 
-	conn, err := grpc.Dial(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
+	conn, err := grpc.NewClient(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
 	require.NoError(t, err)
 	defer conn.Close()
 

pkg/parca/parca.go

@@ -436,7 +436,7 @@ func Run(ctx context.Context, logger log.Logger, reg *prometheus.Registry, flags
 			otelgrpc.WithPropagators(propagators),
 		)),
 	}
-	conn, err := grpc.Dial(flags.ProfileShareServer, opts...)
+	conn, err := grpc.NewClient(flags.ProfileShareServer, opts...)
 	if err != nil {
 		return fmt.Errorf("failed to create gRPC connection to ProfileShareServer: %s, %w", flags.ProfileShareServer, err)
 	}
@@ -720,7 +720,7 @@ func runForwarder(
 		}))
 	}
 
-	conn, err := grpc.Dial(flags.StoreAddress, opts...)
+	conn, err := grpc.NewClient(flags.StoreAddress, opts...)
 	if err != nil {
 		return fmt.Errorf("failed to create gRPC connection: %w", err)
 	}

pkg/parca/parca_test.go

@@ -54,7 +54,7 @@ import (
 )
 
 func getShareServerConn(t Testing) sharepb.ShareServiceClient {
-	conn, err := grpc.Dial("api.pprof.me:443", grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{})))
+	conn, err := grpc.NewClient("api.pprof.me:443", grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{})))
 	require.NoError(t, err)
 	return sharepb.NewShareServiceClient(conn)
 }
@@ -86,7 +86,7 @@ func benchmarkSetup(ctx context.Context, b *testing.B) (profilestorepb.ProfileSt
 	var conn grpc.ClientConnInterface
 	err := backoff.Retry(func() error {
 		var err error
-		conn, err = grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
+		conn, err = grpc.NewClient(addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
 		if err != nil {
 			// b.Logf("failed to connect to parca: %v", err)
 			return err

pkg/query/columnquery_test.go

@@ -53,7 +53,7 @@ import (
 )
 
 func getShareServerConn(t Testing) sharepb.ShareServiceClient {
-	conn, err := grpc.Dial("api.pprof.me:443", grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{})))
+	conn, err := grpc.NewClient("api.pprof.me:443", grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{})))
 	require.NoError(t, err)
 	return sharepb.NewShareServiceClient(conn)
 }