added factory dependencies for Resolc Compiler #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkhry
reviewed
Jul 14, 2025
| @@ -83,6 +83,7 @@ impl From<ResolcContract> for foundry_compilers_artifacts_solc::Contract { | |||
| ewasm: None, | |||
| ir_optimized: contract.ir_optimized, | |||
| ir_optimized_ast: None, | |||
| factory_dependencies: contract.factory_dependencies, | |||
There was a problem hiding this comment.
maybe extensions ?
namely:
enum Extensions {
None,
Resolc(ResolcExtras)
}and corresponding methods like
contract.resolc_extras : () -> Option<ResolcExtras>
simillar to what is already was implemented for Bytecode in this repo
There was a problem hiding this comment.
why extensions went to resolcContract when the solc contract is the one to be extended?
It doesnt make any sense semantically, we need to extend the solc contract, resolc contract is already a superset of solc contract (for a subset of values, e.g. factory_dependencies and others).
pkhry
reviewed
Jul 14, 2025
| @@ -59,6 +59,9 @@ pub struct ConfigurableContractArtifact { | |||
| /// The identifier of the source file | |||
| #[serde(default, skip_serializing_if = "Option::is_none")] | |||
| pub id: Option<u32>, | |||
| /// Factory dependencies for the contract. | |||
| #[serde(default, skip_serializing_if = "Option::is_none")] | |||
| pub factory_dependencies: Option<BTreeMap<String, String>>, | |||
There was a problem hiding this comment.
why Option is needed?
BtreeMap::empty should pretty much be equivalent to Option::None
soul022
force-pushed
the
soul22/factoryDependencies
branch
from
a37ad61 to
d00695b
Compare
pkhry
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional factory_dependencies field (a BTreeMap<String, String>) to Contract and ConfigurableContractArtifact in the resolc, solc, and vyper crates, with serde defaults to avoid breaking existing artifacts.
Propagated this new field through all From<…> conversions so parsed contracts now carry factory‐dependency metadata.
Updated the ArtifactOutput logic in the compilers crate to include factory_dependencies in emitted artifacts.