Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rococo Runtime Spec Version #3171

Conversation

alistair-singh
Copy link
Contributor

To deploy fix: #3108 and unblock the re-initialization of Ethereum bridge.

@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Feb 1, 2024
@@ -150,7 +150,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("rococo"),
impl_name: create_runtime_str!("parity-rococo-v2.0"),
authoring_version: 0,
spec_version: 1_006_002,
spec_version: 1_006_003,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorPopelyaev is this ok? or change to 1_700_000? 1.7.0 release was branched off yesterday, and if we need to release BridgeHubRococo from master

Copy link
Member

@ggwpez ggwpez Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.7 would be on the release branch then, not master. I dont know if the runtimes from master should be used anywhere?

@acatangiu
Copy link
Contributor

acatangiu commented Feb 1, 2024

@alistair-singh what do you say we just wait for 1.7.0 release to come out (will be published over the weekend I believe) then just use that?

in the meantime I believe you can re-initialize the Ethereum bridge without said fix - it'll be a problem only if we end up stalling BEEFY for multiple sessions before the 1.7.0 upgrade, which is unlikely

  • the current BEEFY light-client can just work as it did before, making progress from non-mandatory commits
  • once we upgrade to 1.7.0, it will also correctly accept mandatory commits (which the fix addresses)

wdyt?

@ggwpez ggwpez self-requested a review February 1, 2024 15:14
@alistair-singh
Copy link
Contributor Author

I am happy to wait for 1.7. We can close this PR. If a stall happens before 1.7 is rolled out we can always re-initialize again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants