rpc-v2/archive: Rename archive call method result to value #7885
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
changed the title
Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
approved these changes
Mar 11, 2025
niklasad1
reviewed
Mar 11, 2025
| @@ -49,7 +49,7 @@ pub enum MethodResult { | |||
| impl MethodResult { | |||
| /// Constructs a successful result. | |||
| pub fn ok(result: impl Into<String>) -> MethodResult { | |||
| MethodResult::Ok(MethodResultOk { success: true, result: result.into() }) | |||
| MethodResult::Ok(MethodResultOk { success: true, value: result.into() }) | |||
There was a problem hiding this comment.
is this only used by the archive API?
why not move it to the archive module so it doesn't get used by something else?
There was a problem hiding this comment.
yes, these are only used by the archive APIs
niklasad1
approved these changes
Mar 11, 2025
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/stabilizing-the-archive-rpc-v2-methods/12058/1 |
niklasad1
reviewed
Mar 20, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the archive_call method result to align with the rpc-v2 spec:
Previously, the method result was encoded to a json containing a "result" field, however the spec specifies a "value" field. This aims to rectify that.
cc @paritytech/subxt-team