[Draft][WIP] UncheckedExtrinsic: lazily decode and limit the call
#7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
the
T17-primitives
serban300
force-pushed
the
unchecked-extrinsic
branch
5 times, most recently
from
368c27a to
4e1cafb
Compare
serban300
changed the title
UncheckedExtrinsic: lazy decoding + set a memory limit when decoding the callUncheckedExtrinsic: lazily decode and limit the call
serban300
force-pushed
the
unchecked-extrinsic
branch
2 times, most recently
from
520f415 to
099a094
Compare
bkchr
reviewed
Mar 13, 2025
| @@ -1462,13 +1465,15 @@ impl_runtime_apis! { | |||
| uxt: <Block as BlockT>::Extrinsic, | |||
| len: u32, | |||
| ) -> pallet_transaction_payment_rpc_runtime_api::RuntimeDispatchInfo<Balance> { | |||
| TransactionPayment::query_info(uxt, len) | |||
| let mut uxt = uxt; | |||
There was a problem hiding this comment.
Nice ! Thanks ! Will use this feature after it's merged.
serban300
force-pushed
the
unchecked-extrinsic
branch
from
099a094 to
dbee656
Compare
This was referenced Mar 14, 2025
serban300
added
the
I9-optimisation
serban300
force-pushed
the
unchecked-extrinsic
branch
from
dbee656 to
506a5bf
Compare
serban300
force-pushed
the
unchecked-extrinsic
branch
from
506a5bf to
51b5cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7360
Closes #4255
This PR:
RuntimeCallinside anUncheckedExtrinsicRuntimeCallinside anUncheckedExtrinsicThis is a significant rework of #4296. The main problem with #4296 was that it was always decoding a call at least twice. This PR comes with a different approach, that avoids the need to decode twice.