Removed pallet:getter from Snowbridge pallets
#7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 tasks
muraca
force-pushed
the
getters/snowbridge
branch
from
05efc9a to
f7a0bb5
Compare
muraca
commented
Mar 13, 2025
|
@vgeddes @alistair-singh @yrong do we actually use these getters somewhere? Maybe we can remove some/all of them? |
bkchr
approved these changes
Mar 17, 2025
|
@claravanstaden we normally merge these changes with the manual get functions. Maybe someone downstream uses them. (BIG MAYBE :D) |
claravanstaden
approved these changes
Mar 18, 2025
bkontur
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
@claravanstaden If you really don't need them and want to remove them and we want to be nice, then let's deprecate them with a message like "Will be removed, e.g., stable2509.". Otherwise, just remove them :)
|
Just remove, nobody uses Snowbridge components other than Snowbridge |
vgeddes
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3326
As per title, the
pallet:getterusage has been removed from:snowbridge-pallet-ethereum-clientsnowbridge-pallet-inbound-queuesnowbridge-pallet-outbound-queuesnowbridge-pallet-systemGetters have been implemented manually for all storage items where an auto-generated one has been removed.
polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp