Add digest processor xcm emulator #7915
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@franciscoaguirre any opinion for this? |
acatangiu
added
T10-tests
bkchr
reviewed
Mar 20, 2025
bkchr
approved these changes
Mar 21, 2025
|
/cmd fmt |
auto-merge was automatically disabled
March 21, 2025 12:55
Pull Request is not mergeable
Merged
via the queue into
paritytech:master
with commit Mar 21, 2025
1a514f6
250 of 256 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently parachains are injecting through the xcm-emulator the default digests in each block, something that can prevent testing certain consensus aspects.
We propose to add the type
DigestProvider, which needs to implement the traitConvert<blockNumber, Digest>. The idea is that we can call the implementation of this trait before initializing every block, and thus, allowing us to inject custom digests provided by this trait.Obviously the default behavior persists if you set this type to
().The utilization of the
Converttrait was arbitrary, as it was the easiest to accomplish the solution. I am not against using a custom trait defined for this purpose if that is preferred.