Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digest processor xcm emulator #7915

Merged

Conversation

girazoki
Copy link
Contributor

@girazoki girazoki commented Mar 13, 2025

Currently parachains are injecting through the xcm-emulator the default digests in each block, something that can prevent testing certain consensus aspects.

We propose to add the type DigestProvider, which needs to implement the trait Convert<blockNumber, Digest>. The idea is that we can call the implementation of this trait before initializing every block, and thus, allowing us to inject custom digests provided by this trait.

Obviously the default behavior persists if you set this type to ().

The utilization of the Convert trait was arbitrary, as it was the easiest to accomplish the solution. I am not against using a custom trait defined for this purpose if that is preferred.

@girazoki
Copy link
Contributor Author

@franciscoaguirre any opinion for this?

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, go ahead

@acatangiu acatangiu added T10-tests This PR/Issue is related to tests. R0-silent Changes should not be mentioned in any release notes labels Mar 20, 2025
@bkchr
Copy link
Member

bkchr commented Mar 21, 2025

/cmd fmt

@bkchr bkchr enabled auto-merge March 21, 2025 12:12
@bkchr bkchr added this pull request to the merge queue Mar 21, 2025
auto-merge was automatically disabled March 21, 2025 12:55

Pull Request is not mergeable

Merged via the queue into paritytech:master with commit 1a514f6 Mar 21, 2025
250 of 256 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants