Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staking] Fix: migrate_currency supports cases with leftover old staking locks #7933

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Mar 14, 2025

closes #7931.

TODO

  • Rerun migrate_currency for all accounts with current state of testnet/mainnets in a remote externality test.

Migration stats:

Westend: success: 73023, err: 0, total force withdrawn stake: 340726297547707, no_migration_needed: 53
Kusama: success: 26096, err: 0, total force withdrawn stake: 893395700711867, no_migration_needed: 0
Polkadot: success: 56044, err: 0, total force withdrawn stake: 157489603546239, no_migration_needed: 0

@Ank4n Ank4n added I2-bug The node fails to follow expected behavior. T2-pallets This PR/Issue is related to a particular pallet. A4-needs-backport Pull request must be backported to all maintained releases. R0-silent Changes should not be mentioned in any release notes labels Mar 15, 2025
@Ank4n Ank4n marked this pull request as ready for review March 16, 2025 08:52
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13881839484
Failed job name: fmt

@kianenigma
Copy link
Contributor

The largest account that has to force_withdraw around 150 DOTs is https://polkadot.subscan.io/account/13YMK2eb11XSc7CJgqDBrNswzLpMMc8pWkzxYkqaMruPG8xk which is a parachain sovereign account. It makes sense because they have a lot of reserve.

What I ask here is to make sure to post a final list of these accounts right before the fellowship runtimes upgrade to 2503 in the runtimes PR for transparency.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have edited the test to print a few more stats + pass the try-state checks (by bringing in the VoterList and other pallets).

LGTM

@Ank4n Ank4n requested review from tdimitrov and a team March 16, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. I2-bug The node fails to follow expected behavior. R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Staking] migrate_currency fails in some scenarios
2 participants