feat: add chain_spec_key_types support for custom session keys #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenzelPenzel
force-pushed
the
chain-spec-custom-session-keys
branch
from
c03ba4c to
8eb7b3f
Compare
DenzelPenzel
commented
Dec 12, 2025
pepoviola
reviewed
Jan 6, 2026
pepoviola
reviewed
Jan 6, 2026
|
|
||
| pub fn get_default_chain_spec_key_types(is_asset_hub_polkadot: bool) -> Vec<ChainSpecKeyType> { | ||
| let predefined_schemes = get_predefined_schemes(is_asset_hub_polkadot); | ||
| let default_keys = [ |
Collaborator
There was a problem hiding this comment.
Maybe we can refactor this to convert the resulting HashMap into the Vec directly.
Contributor
Author
There was a problem hiding this comment.
Yep, right, actually this fn isn’t used in the codebase; I removed it.
pepoviola
reviewed
Jan 6, 2026
Collaborator
pepoviola
left a comment
pepoviola
left a comment
There was a problem hiding this comment.
Looks good, some small comments inline.
Thx!
…sion-keys # Conflicts: # crates/orchestrator/src/generators/chain_spec.rs # crates/orchestrator/src/network_spec.rs
pepoviola
approved these changes
Jan 9, 2026
Collaborator
|
thanks @DenzelPenzel !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #473
chain_spec_key_typesfield inNodeConfigandNodeSpecto specify session key types for chain spec injectionchain_spec_key_typesmodule for parsing key type specifications