64 bit warning and string format fixes. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n active achitecture so that when JSCocoa is included as a subproject in a 32 bit project the correct arch is available during debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull ups the warning levels to -Wall and -Wextra. We have nothing to loose by going that bit further and it gives a warning free build on 32/64 bit targets.
I was moving my app from 32 -> 64 bit and I was determined to eliminate as many warnings as I could in the hope of getting 64 bit up and running.
See this http://programmers.stackexchange.com/questions/122608/clang-warning-flags-for-objective-c-development. -Wextra might be a bit far but it doesn't hurt too much.
I fixed all the 64 bit type size and string format warnings as recommended in the Apple 64 bit transition guide. I think they should be merged even if the -Wextra changes are rejected.