fix: Add support for Dart 3.6, 3.7; remove support for Dart 3.2, 3.3, 3.4, 3.5, 3.3
#1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 43.37% 43.72% +0.35%
==========================================
Files 61 61
Lines 3463 3465 +2
==========================================
+ Hits 1502 1515 +13
+ Misses 1961 1950 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit updates the mockito dependency to version 5.4.5 and regenerates the mock files accordingly.
Fix mocks generation due to a change in mocktail package.
mtrezza
reviewed
Apr 19, 2025
| @@ -53,8 +47,13 @@ jobs: | |||
| run: (cd packages/dart && dart run build_runner build --delete-conflicting-outputs) | |||
| - name: Analyze code | |||
| run: dart analyze packages/dart --fatal-infos | |||
| - name: Lint For Fix Bug mocks | |||
| @@ -18,36 +18,40 @@ topics: | |||
| - backend | |||
|
|
|||
| environment: | |||
| sdk: ">=3.2.6 <4.0.0" | |||
| sdk: ^3.6.2 | |||
There was a problem hiding this comment.
I'm unsure whether removing the upper bound is a good idea, but since even minor versions changes can be breaking, let's try.
mtrezza
added
the
state:breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Add support for Dart
3.6,3.7; remove support for Dart3.2,3.3,3.4,3.5,3.3Closes: #1026
Approach
n/a
Tasks