Skip to content

fix: Auth adapter VKontakte not working with new API#8640

Open
MattKirchhof wants to merge 1 commit into
parse-community:alphafrom
MattKirchhof:fix-vkontakte-adapter
Open

fix: Auth adapter VKontakte not working with new API#8640
MattKirchhof wants to merge 1 commit into
parse-community:alphafrom
MattKirchhof:fix-vkontakte-adapter

Conversation

@MattKirchhof

@MattKirchhof MattKirchhof commented Jun 16, 2023

Copy link
Copy Markdown

Pull Request

Issue

#8626

Closes: #8626

Approach

Remove previously unnecessary API call that now fails. Bump the api version for good practice.

@parse-github-assistant

parse-github-assistant Bot commented Jun 16, 2023

Copy link
Copy Markdown

Thanks for opening this pull request!

@mtrezza mtrezza changed the title fix:Remove unnecessary and deprecated api call, bump api version fix: Remove unnecessary and deprecated api call, bump api version Jun 16, 2023
@mtrezza mtrezza changed the title fix: Remove unnecessary and deprecated api call, bump api version fix: Auth adapter vkontakte not working for new API Jun 16, 2023
@mtrezza mtrezza changed the title fix: Auth adapter vkontakte not working for new API fix: Auth adapter VKontakte not working for new API Jun 16, 2023
@mtrezza mtrezza changed the title fix: Auth adapter VKontakte not working for new API fix: Auth adapter VKontakte not working with new API Jun 16, 2023
@codecov

codecov Bot commented Jun 16, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (e2e51d9) 94.43% compared to head (721cffd) 94.42%.

❗ Current head 721cffd differs from pull request most recent head dd29b60. Consider uploading reports for the commit dd29b60 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8640      +/-   ##
==========================================
- Coverage   94.43%   94.42%   -0.01%     
==========================================
  Files         184      184              
  Lines       14613    14605       -8     
==========================================
- Hits        13800    13791       -9     
- Misses        813      814       +1     
Impacted Files Coverage Δ
src/Adapters/Auth/vkontakte.js 100.00% <100.00%> (+10.52%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is removing a lot of checks from the adapter; for example it is accessing properties of variables that may not be set in the adapter, causing the server to crash. I suggest to only change what is necessary in the adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vkontakte Adapter fails authentication.

2 participants