fix: Auth adapter VKontakte not working with new API#8640
Open
MattKirchhof wants to merge 1 commit into
Open
Conversation
Thanks for opening this pull request! |
vkontakte not working for new API
vkontakte not working for new API
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8640 +/- ##
==========================================
- Coverage 94.43% 94.42% -0.01%
==========================================
Files 184 184
Lines 14613 14605 -8
==========================================
- Hits 13800 13791 -9
- Misses 813 814 +1
☔ View full report in Codecov by Sentry. |
mtrezza
requested changes
Jun 16, 2023
mtrezza
left a comment
Member
There was a problem hiding this comment.
This change is removing a lot of checks from the adapter; for example it is accessing properties of variables that may not be set in the adapter, causing the server to crash. I suggest to only change what is necessary in the adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
#8626
Closes: #8626
Approach
Remove previously unnecessary API call that now fails. Bump the api version for good practice.