feat: Change default value of Parse Server option encodeParseObjectInCloudFunction to true

[dblythy]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Closes: FILL_THIS_OUT

Approach

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)
• Add security check
• Add new Parse Error codes to Parse JS SDK

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your pull request will be closed. If a field does not apply to the pull request, fill in n/a.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (7f66629) to head (fbdbc6f).
Report is 3 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #9527   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files         186      186           
  Lines       14807    14807           
=======================================
  Hits        13847    13847           
  Misses        960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtrezza]

This looks odd. We eventually want to remove the option, but the deprecation message reads more like we're only planning to change the default value. So we cannot say that the status of the deprecation is "removed" if we just change the default value. I believe the default value should have been changed in PS7, but it wasn't, because then the order would have been:

• add deprecation in PS6 --> done
• change default value in PS7 --> not done
• remove option in PS8

We can either remove the option now or only change the default value now, correct the deprecation message and remove the option in PS9. Removing the option in PS8 would not violate our deprecation policy requirement to notify for the duration of at least 1 major release, but it's little code to maintain and due to the confusing deprecation message I'd say let's keep it for now and remove in PS9.

[mtrezza]

We still need a deprecation warning logged if the option is set to false, with a message that we'll remove the option in a future version. Could you please add that?

[mtrezza]

BREAKING CHANGE: The default value of Parse Server option encodeParseObjectInCloudFunction changes to true; the option has been deprecated and will be removed in a future version.

[parseplatformorg]

🎉 This change has been released in version 8.0.0-alpha.5