refactor: Reorganize transformInteriorValue#9566
Open
kassiansun wants to merge 2 commits intoparse-community:alphafrom
Open
refactor: Reorganize transformInteriorValue#9566kassiansun wants to merge 2 commits intoparse-community:alphafrom
kassiansun wants to merge 2 commits intoparse-community:alphafrom
Conversation
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
|
🚀 Thanks for opening this pull request! |
kassiansun
force-pushed
the
alpha
branch
2 times, most recently
from
9ec6cfd to
d4c3acf
Compare
This code was checking a constantly true condition value !== CannotTransform, that's why the code was not properly handling nested structure properly, The code introduced by parse-community#8446 fixed this logic, by introducing another duplicated piece of code. This commit simplifies the logic here to reflect the original purpose.
Author
|
This PR should also fix the (broken since #8446) |
Member
|
@kassiansun Thank you for the PR, and you patience in waiting for review. I've rebased it and restarted the CI. |
mtrezza
reviewed
Apr 7, 2025
Author
These cases are handled later in the function, the logic was duplicated twice |
Member
|
Could you provide more details? Where are they handled? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
This code was checking a constantly true condition value !== CannotTransform, that's why the code was not properly handling nested structure properly, The code introduced by #8446 fixed this logic, by introducing another duplicated piece of code.
Closes: #9567
Approach
This commit simplifies the logic here to reflect the original purpose.