Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable kafka in all unix builds #1107

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 16, 2025

Fixes #XXXX.

Description

As the CI points out, librdkafk linking for some unix targets doesn't work as expected. This PR will have to remain open until the underlying problem is figured out.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12840945205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 12.715%

Files with Coverage Reduction New Missed Lines %
src/option.rs 1 0.0%
Totals Coverage Status
Change from base Build 12840753936: 0.0%
Covered Lines: 2459
Relevant Lines: 19340

💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review January 17, 2025 19:00
@de-sh de-sh marked this pull request as draft January 17, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants