Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test + refactor: staging #1129

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

test + refactor: staging #1129

wants to merge 31 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 21, 2025

Fixes #XXXX.

Description

While trying to audit the code to perform staging, I made these improvements that reduces unnecessary copies and added tests to critical parts of the flow and hence improve coverage.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 13032630803

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 426 of 618 (68.93%) changed or added relevant lines in 16 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.4%) to 15.332%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/ingest/ingestor_logstream.rs 0 1 0.0%
src/migration/metadata_migration.rs 0 1 0.0%
src/sync.rs 0 1 0.0%
src/handlers/http/health_check.rs 0 2 0.0%
src/handlers/http/logstream.rs 0 2 0.0%
src/handlers/http/modal/query/querier_logstream.rs 0 2 0.0%
src/metadata.rs 0 2 0.0%
src/query/stream_schema_provider.rs 0 2 0.0%
src/handlers/airplane.rs 0 4 0.0%
src/utils/mod.rs 33 37 89.19%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/health_check.rs 1 0.0%
src/query/stream_schema_provider.rs 1 26.71%
src/handlers/airplane.rs 3 0.0%
Totals Coverage Status
Change from base Build 13006822034: 2.4%
Covered Lines: 2939
Relevant Lines: 19169

💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review January 23, 2025 14:25
@de-sh de-sh marked this pull request as draft January 23, 2025 14:58
@de-sh de-sh marked this pull request as ready for review January 29, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants