Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simply store StreamType #1136

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 27, 2025

Fixes #XXXX.

Description

No functional changes, just saves on cost of conversion into String


How to test

  1. Start a parseable instance without this change.
  2. Create a stream, push data onto it.
  3. Shutdown parseable, update binary with this change.
  4. Restart parseable with same config as before, ensure internal streams are considered as such and no conflicts in working.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 13025754244

Details

  • 0 of 21 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 12.949%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/utils/logstream_utils.rs 0 1 0.0%
src/storage/mod.rs 0 1 0.0%
src/storage/object_storage.rs 0 1 0.0%
src/handlers/http/modal/query/querier_logstream.rs 0 3 0.0%
src/metadata.rs 0 7 0.0%
src/handlers/http/logstream.rs 0 8 0.0%
Totals Coverage Status
Change from base Build 13025432081: -0.002%
Covered Lines: 2477
Relevant Lines: 19129

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 5294779 into parseablehq:main Jan 29, 2025
11 checks passed
@de-sh de-sh deleted the stream-type branch January 29, 2025 18:25
de-sh added a commit to de-sh/parseable that referenced this pull request Jan 31, 2025
nitisht pushed a commit that referenced this pull request Feb 1, 2025
Signed-off-by: Devdutt Shenoi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants