Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change struct keys from ion to strings for string tests #128

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Oct 22, 2024

A handful of tests used quoted ion symbols as keys in structs, rather than strings. This seems to be a typo that happens to work as the ion is coerced into text.

These were originally ported from an old version of the PartiQL-Lang-Kotlin test scripts: https://github.com/partiql/partiql-lang-kotlin/blob/v0.7.0-alpha/testscript/pts/test-scripts/primitive-types/naughty-strings.sqlts#L20

This PR changes the keys to strings.

E.g.,

{ `key`: 'value' } -> { 'key': 'value'}


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though it does make me think whether we even want to coerce symbols to strings in the future. I'm not entirely sure.

The intention of the original commit, though, seems clear that it was wrong to use Ion symbols for these tests.

@jpschorr jpschorr merged commit 9467d28 into main Oct 22, 2024
4 checks passed
@jpschorr jpschorr deleted the fix-string-quotes branch October 22, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants