feat(autofill): add setting to control TOTP copy on autofill #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autofilling credentials for a resource that has TOTP configured, automatically copy the current TOTP code to the clipboard. This allows users to quickly paste the TOTP code after the password is filled, streamlining the login process for 2FA-enabled accounts. - Add TotpService to generate TOTP codes using jsSHA (RFC 6238) - Modify AutofillController to copy TOTP after filling credentials - TOTP is copied with 30-second auto-clear (using existing clipboard service) - Silently handles errors to not disrupt autofill if TOTP copy fails
Add a user-configurable setting to enable/disable automatic TOTP clipboard copy when autofilling credentials. Default is OFF (opt-in). This builds on the TOTP copy feature and adds: - AutofillSettingEntity with schema validation - AutofillSettingLocalStorage for persisting user preference - Get/Set controllers for the setting - AutofillSettingEvents for worker communication - Integration in appPagemod and quickAccessPagemod 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
AutofillSettingEntity- Entity with schema validation for thecopyTotpOnAutofillboolean settingAutofillSettingLocalStorage- Local storage service to persist user preferenceGetAutofillSettingController/SetAutofillSettingController- Controllers to get/set the settingAutofillSettingEvents- Event listeners for worker communicationAutofillControllerto check the setting before copying TOTPappPagemod.jsandquickAccessPagemod.jsNote to reviewers
This PR provides an alternative approach to PR #250. Passbolt can choose to:
The backend infrastructure is ready; UI integration in passbolt-styleguide would be needed to expose the toggle in settings.
Test plan
🤖 Generated with Claude Code