Skip to content

Conversation

arpitpatelsitapur
Copy link

@arpitpatelsitapur arpitpatelsitapur commented Aug 19, 2025

Summary by CodeRabbit

  • Documentation
    • Added a “Issues You May Face” troubleshooting section with guidance for:
      • Pickle errors when caching non-picklable objects; recommends avoiding cache for such objects and using session state instead, with example usage.
      • App slowness due to high memory usage; suggests switching to smaller language models and embeddings, with initialization examples.
    • No functional changes to the application behavior.

Copy link
Contributor

coderabbitai bot commented Aug 19, 2025

Walkthrough

Adds an “Issue You may face” troubleshooting section to rag-with-dockling/README.md documenting two issues (pickle error with Streamlit caching and app slowness due to memory) with explanations and code snippets. No code or API changes.

Changes

Cohort / File(s) Summary
Docs - Troubleshooting
rag-with-dockling/README.md
Added troubleshooting section with two issues: avoiding @st.cache_resource for non-picklable objects (use st.session_state) and performance guidance to use smaller models/embeddings; included example snippets.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A nibble of notes in README land,
I twitch my ears and understand:
Cache not what cannot be pickled, friend—
Use session state, your troubles end.
If RAM protests and tempos slow,
Pick smaller models; watch them go!
Thump-thump—docs polished, onward hop!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
rag-with-dockling/README.md (5)

22-22: Pluralize and normalize heading capitalization

Improve readability and polish:

-## 🐞 Issue You may face
+## 🐞 Issues you may face

23-30: Make the Streamlit workaround snippet copy-pasteable

Add explicit imports so readers can drop this into their app without guessing dependencies.

-> ```python
-> if "llm_client" not in st.session_state:
->     st.session_state.llm_client = Ollama(model="llama3.2")
-> ```
+> ```python
+> import streamlit as st
+> from llama_index.llms.ollama import Ollama
+>
+> if "llm_client" not in st.session_state:
+>     st.session_state.llm_client = Ollama(model="llama3.2")
+> ```

Optional: You could also add a one-liner that clarifies the root cause, e.g., “Some client objects aren’t picklable; avoid caching them with @st.cache_resource—prefer session state.”


32-33: Fix grammar and casing in section title and text

Minor grammar improvements and brand casing.

-### 2. App Extremely Slow (incase Used another Large Model)
-This often happens due to high memory usage. `ollama` was observed using 10+ GB RAM on an 8 GB Mac, leading to heavy swapping. Large embedding models like `bge-large-en-v1.5` also consume significant memory.
+### 2. App is extremely slow (in case you used a large model)
+This often happens due to high memory usage. `Ollama` was observed using 10+ GB RAM on an 8 GB Mac, leading to heavy swapping. Large embedding models like `bge-large-en-v1.5` also consume significant memory.

37-39: Fix nested list indentation to satisfy markdownlint (MD007)

Indent nested bullets by two spaces (not four).

->     * `qwen2:1.5b`
->     * `llama3.2:1b`
->     * `mistral:7b-instruct-q4_K_M`
+>   * `qwen2:1.5b`
+>   * `llama3.2:1b`
+>   * `mistral:7b-instruct-q4_K_M`

35-44: Optional additions to help reduce memory pressure further

Consider adding one more tip that often helps users:

 > ✅ **Solution**:
 > * **Use smaller Ollama models**:
 >   * `qwen2:1.5b`
 >   * `llama3.2:1b`
 >   * `mistral:7b-instruct-q4_K_M`
 > * **Use smaller embeddings**:
 >     ```python
 >     HuggingFaceEmbedding(model_name="BAAI/bge-small-en-v1.5")
 >     ```
+> * **Prefer quantized variants and smaller context windows** (e.g., `q4_K_M`, reduce `context_window` where supported) to cut peak RAM usage.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 033c6a5 and 47f7a71.

📒 Files selected for processing (1)
  • rag-with-dockling/README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
rag-with-dockling/README.md

[grammar] ~23-~23: There might be a mistake here.
Context: ...e You may face ### 1. Pickle Error with @st.cache_resource The app might fail with: `An error occur...

(QB_NEW_EN)


[grammar] ~32-~32: There might be a mistake here.
Context: ...y Slow (incase Used another Large Model) This often happens due to high memory us...

(QB_NEW_EN)


[grammar] ~35-~35: There might be a mistake here.
Context: ...e significant memory. > ✅ Solution: > * Use smaller Ollama models: > * `qw...

(QB_NEW_EN)

🪛 markdownlint-cli2 (0.17.2)
rag-with-dockling/README.md

37-37: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


38-38: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)


39-39: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

🔇 Additional comments (1)
rag-with-dockling/README.md (1)

22-44: Nice, pragmatic troubleshooting section

The two issues you documented are common and your remedies are practical. These will save users time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant