Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefMap Check Should Resolve Ref Fragment #16

Closed
wants to merge 339 commits into from
Closed

RefMap Check Should Resolve Ref Fragment #16

wants to merge 339 commits into from

Conversation

jordanross-wf
Copy link

Issue:

  • RefMap Check Should Resolve Ref Fragment

Solution:

  • Both sync and async ref resolution methods now use a shared helper method that checks refMap for baseUri and resolves fragment if present.

Michael Carter and others added 30 commits April 18, 2018 10:24
feat(package): fix int parsing behavior for draft6 | all tests passing
87aa19e
fix(package): allow createFromUrl functions to specify schemaVersion …
1cefe71 
…as well
@michaelcarter-wf
Merge pull request #11 from michaelcarter-wf/update_draft4_schema_tests
be4c208 
EPL-8413 feat(package): update draft4 tests
Merge branch '2.0.0_wip' of github.com:workiva/json_schema into draft…
536622d 
…6_update
fix(package): cr fixes
2fee3be
fix(package): cr fixes
9fd1fcf
@michaelcarter-wf
Merge pull request #12 from michaelcarter-wf/draft6_update
caeb6db 
EPL-8414 feat(package): support JSON Schema draft6
feat(package): add a method for consumers to specify their own $ref p…
97c21ad 
…roviders.
feat(package): recursive ref tests passing
91ba717
@travisreed-wf
Update Dockerfile
47dafe9
@travisreed-wf
Update Dockerfile
d01115b
@travisreed-wf
Update Dockerfile
9c0bd43
@michaelcarter-wf
Merge pull request #14 from travisreed-wf/patch-1
28f143d 
Update Dockerfile to Mirror smithy.yaml
@michaelcarter-wf
Merge pull request #10 from Workiva/smithy_dockerfile_migration
8220bcd 
BUILDTOOLS-2329: Update Dockerfile to mirror smithy.yaml
@bcko
Update .gitignore to new dart_tool pub cache
3e063ad 
dart-lang/sdk#32030
@michaelcarter-wf
Merge pull request #16 from bcko/patch-1
f4ac8f2 
Update .gitignore to new `dart_tool` pub cache
feat(remote-ref): fix ref within remote ref tests - 7 tests failing
ede8704
feat(package): added inheritance to ids and refs
0afe923
imp(package): remove parentOrRoot, not needed
60189a4
fix(package): remove unnecessary parameter
e532f6e
feat(package): all draft06 tests passing #awyeah
83250a2
fix(json-schema): cr fixes
8a76f80
chore(json-schema): remove prints
1ea72b1
fix(json-schema): hide members that don't need to be public
b4c54c5
chore(json-schema): remove another public member
fa0a763
cleanup(package): remove ref provider for now, need to do sync work f…
f8601cb 
…irst
Merge branch 'master' of github.com:workiva/json_schema into ref_prov…
41ba846 
…ider
chore(package): remove for refProvider related stuff
b4e77c7
Merge branch 'ref_provider' of github.com:michaelcarter-wf/json_schem…
9353656 
…a into sync_schemas_2

# Conflicts:
#	lib/src/json_schema/json_schema.dart
#	test/unit/vm/json_schema/validation_test.dart
af_new_drydock_image : updates
d2c0aca
jordanross-wf and others added 28 commits February 24, 2021 09:19
@jordanross-wf
Removed untrue statement
9cdee19
@jordanross-wf
Merge remote-tracking branch 'origin/master' into remote-ref-resolution
2d025a3 
# Conflicts:
#	lib/src/json_schema/json_schema.dart
#	pubspec.yaml
@jordanross-wf
Add tests back in
7f33e08
@michaelcarter-wf
chore(tests): update JSON-Schema-Test-Suite
25c99da
@michaelcarter-wf
fix(test): skip tests we don't yet pass
5d9b525
@michaelcarter-wf
Merge branch 'remote-ref-resolution' of github.com:Workiva/json_schem…
131698e 
…a into remote-ref-resolution-plus-new-tests
@rmconsole2-wf
Merge pull request #67 from Workiva/remote-ref-resolution
743c6c8 
CPRO-358 fix(ref-resolution): Logic changes around remote ref resolution
@rmconsole3-wf
Merge pull request #72 from Workiva/remote-ref-resolution-plus-new-tests
29ef241 
CPRO-359: chore(package): update spec tests
@michaelcarter-wf
fix(test): fix test cases involving formats
a365bd8
@jordanross-wf
_refMap now only holds unique ids, base uris. resolving a path on a s…
925528a 
…chema properly walks the schema now instead of just searching the _refMap
@rmconsole4-wk
Merge pull request #73 from Workiva/PROC-709
f5e9613 
PROC-709 fix(test): fix test cases involving formats
@jordanross-wf
Fix fetch from refProvider logic
f711931
@jordanross-wf
RefProvider is now a single class for consumers to pass in
194d9c9
@jordanross-wf
Merge remote-tracking branch 'origin/master' into new-ref-resolution
c13dd6e 
# Conflicts:
#	test/unit/vm/json_schema/validation_test.dart
@jordanross-wf
Added test that shows new recursive ref resolution with json provider
7e4413a
@jordanross-wf
Better test structure
8542ebf
@jordanross-wf @michaelcarter-wf
Apply suggestions from code review
46f82a6 
Co-authored-by: Michael Carter <[email protected]>
@jordanross-wf
Address CR Feedback
90644ee
@jordanross-wf
Merge remote-tracking branch 'origin/new-ref-resolution' into new-ref…
1d47ec3 
…-resolution
@jordanross-wf
Fixed missing single quote
2e79a95
@rmconsole2-wf
Merge pull request #74 from Workiva/new-ref-resolution
bfcb99e 
PROC-727 Ref Storage on Schemas and Path Resolution Changes
@michaelcarter-wf
fix(package): json pointer and uri encoding fixes
5b97749
@michaelcarter-wf
fix(package): utf-16 pattern fixes
77d2f3c
@michaelcarter-wf
chore(package): uncomment and format
dcf0878
@michaelcarter-wf
chore(package): reorder pubspec alpha
5f50ab3
@michaelcarter-wf
chore(utils): remove unused util
98969cc
@rmconsole4-wk
Merge pull request #75 from Workiva/pointer_lib
9649a66 
PROC-728: Fix Encoding and UTF-16 Spec Tests
@jordanross-wf
Better _refMap check in ref fetch logic
76b8e88
@jordanross-wf
Copy link
Author

PR'd to wrong fork, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.