Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #20

Closed
wants to merge 767 commits into from
Closed
Changes from all commits
Commits
Show all changes
767 commits
Select commit Hold shift + click to select a range
1b1bee1
Turns out ecmascript-regex.json actually passes! Remove from list
tomdeering-wf Jan 24, 2022
886ec6c
Update to latest JSON-Schema-Test-Suite
tomdeering-wf Jan 24, 2022
7917cab
Merge pull request #108 from Workiva/td/clarify-skipped-tests
robbielamb-wf Jan 24, 2022
ad8dc94
Merge pull request #109 from Workiva/td/update-test-suite
rmconsole7-wk Jan 24, 2022
d1e2bf5
Merge branch 'support_2019_09' into rl/implement_unevaluated
robbielamb-wf Jan 24, 2022
070032b
Add a quote and links to docs to comment
tomdeering-wf Jan 24, 2022
19fad78
Merge remote-tracking branch 'origin/master' into support_2019_09
tomdeering-wf Jan 24, 2022
299d2c0
Merge pull request #107 from Workiva/td/keyword/ignore-renamed
tomdeering-wf Jan 24, 2022
0c01443
Make the context 'EvaluatedItems' in the validator.
robbielamb-wf Jan 24, 2022
973fd81
Implementation for unevaluated properties.
robbielamb-wf Jan 24, 2022
7ccf14d
Switch subschema inlining to use $defs
tomdeering-wf Jan 24, 2022
53c0565
Additional comments.
robbielamb-wf Jan 24, 2022
b19b4e7
Different dynamic parent for refs.
robbielamb-wf Jan 24, 2022
e4fae14
Merge remote-tracking branch 'origin/support_2019_09' into td/keyword…
tomdeering-wf Jan 24, 2022
e5dd671
Fix logical merge conflict, run vocabulary tests
tomdeering-wf Jan 25, 2022
c80f0c0
json_schema_3.1.0
rmconsole-readonly-wk Jan 25, 2022
09647e8
doc(changes): update changelog
michaelcarter-wf Jan 25, 2022
1e19c13
Merge pull request #113 from Workiva/release_json_schema_3.1.0
rmconsole2-wf Jan 25, 2022
168afdb
Merge pull request #110 from Workiva/td/inline-vocabs-with-defs
tomdeering-wf Jan 25, 2022
85c27cd
Update lib/src/json_schema/validator.dart
robbielamb-wf Jan 25, 2022
711833b
Update lib/src/json_schema/validator.dart
robbielamb-wf Jan 25, 2022
903a402
Updating useages from old functions to new getters.
robbielamb-wf Jan 25, 2022
bb40195
Formatting.
robbielamb-wf Jan 25, 2022
c2cb264
Merge remote-tracking branch 'origin/support_2019_09' into td/keyword…
tomdeering-wf Jan 25, 2022
e1c0d18
Clean up static schema resolution
tomdeering-wf Jan 25, 2022
8ebbada
Only track evaluatedProperties.
robbielamb-wf Jan 25, 2022
de2f0c2
Sanity check that static schema fragment should be empty.
tomdeering-wf Jan 25, 2022
8faa13b
Merge pull request #105 from Workiva/rl/implement_unevaluated
tomdeering-wf Jan 25, 2022
bdbc42b
Just use raw functions since that's idiomatic Dart
tomdeering-wf Jan 25, 2022
18ba75b
Merge remote-tracking branch 'origin/support_2019_09' into rl/impleme…
robbielamb-wf Jan 25, 2022
2de6b6a
Merge remote-tracking branch 'origin/support_2019_09' into td/keyword…
tomdeering-wf Jan 25, 2022
55ea1cd
chore(package): downgrade http dep
polsieira-wk Jan 25, 2022
06b6fbe
chore(package): use range for http version
polsieira-wk Jan 25, 2022
5c1cebc
chore: format
polsieira-wk Jan 25, 2022
1772b1f
chore(package): format and version syntax
michaelcarter-wf Jan 25, 2022
477b2d3
chore: include copywright credit from shelf_cors_headers
polsieira-wk Jan 25, 2022
2b82862
chore: format
polsieira-wk Jan 25, 2022
a4ed6ed
Merge remote-tracking branch 'origin/support_2019_09' into rl/fixup-refs
robbielamb-wf Jan 25, 2022
5c53df4
Merge pull request #114 from Workiva/downgrade_http_version
rmconsole6-wk Jan 25, 2022
5a848b1
Allow probable schema vocab mistakes without warning
tomdeering-wf Jan 25, 2022
0026c50
Handle differing metaschema URI schemes
tomdeering-wf Jan 25, 2022
ef02cb6
Just allow vocabularies to be null for older drafts
tomdeering-wf Jan 25, 2022
6ace9a8
Use single quotes because Dart
tomdeering-wf Jan 25, 2022
89e977d
Adjustments to resolving refs.
robbielamb-wf Jan 25, 2022
cb25741
Make it very easy to add custom json schema tests.
robbielamb-wf Jan 25, 2022
516f8c7
Put back redundant _errors initialization
tomdeering-wf Jan 25, 2022
89f274b
Conditionally replace URI scheme from http to https
tomdeering-wf Jan 25, 2022
1ef2d64
json_schema_3.1.1
rmconsole-readonly-wk Jan 25, 2022
69c0bb8
Merge pull request #116 from Workiva/release_json_schema_3.1.1
rmconsole3-wf Jan 25, 2022
b1b417b
Merge pull request #106 from Workiva/td/keyword/vocabulary
robbielamb-wf Jan 25, 2022
734f15c
First pass at filling out draft 2020 support.
robbielamb-wf Jan 25, 2022
434dcae
Add validateWithResults, deprecate validate
tomdeering-wf Jan 25, 2022
0a1d882
Fix merge mistake
tomdeering-wf Jan 25, 2022
8ad467a
Address CR comments from PR #177
tomdeering-wf Jan 25, 2022
0eedc33
Make isValid a method
tomdeering-wf Jan 25, 2022
0a39ab8
Fix example src import
tomdeering-wf Jan 26, 2022
4677791
Merge remote-tracking branch 'origin/support_2019_09' into support_20…
robbielamb-wf Jan 26, 2022
9b3374d
Hack in supported vocabularies support for draft2020.
robbielamb-wf Jan 26, 2022
b845d96
Merge remote-tracking branch 'origin/support_2019_09' into rl/impleme…
robbielamb-wf Jan 26, 2022
906d97b
Merge remote-tracking branch 'origin/support_2019_09' into rl/fixup-refs
robbielamb-wf Jan 26, 2022
5b97c1a
chore(package): remove all schemadot references
michaelcarter-wf Jan 26, 2022
5634451
Add a missing space into a comment.
robbielamb-wf Jan 26, 2022
67a2e12
chore(package): remove all no-op globals for specific envs
michaelcarter-wf Jan 26, 2022
6063307
chore(package): remove deprecated refprovider types
michaelcarter-wf Jan 26, 2022
932ba11
chore(package): format
michaelcarter-wf Jan 26, 2022
c54d6fd
Merge branch 'rl/implement_unevaluatedproperties' into rl/fixup-refs
robbielamb-wf Jan 26, 2022
030f123
Move pubic method on JsonSchema into a private method in the validator.
robbielamb-wf Jan 26, 2022
ca8cfab
Remove dynamic parent code from the JsonSchema objects.
robbielamb-wf Jan 26, 2022
26315a1
Reset some state.
robbielamb-wf Jan 26, 2022
8567de5
Add a wall of text comment.
robbielamb-wf Jan 26, 2022
5a291cc
Move custom tests into their own folder.
robbielamb-wf Jan 26, 2022
077bcdd
Don't comment out a bunch of tests
robbielamb-wf Jan 26, 2022
5b250f9
Merge branch 'rl/fixup-refs' into support_2020_12
robbielamb-wf Jan 26, 2022
ff0040b
WIP. Make more tests pass.
robbielamb-wf Jan 26, 2022
5bccfee
Validators shouldn't be reused. (But parsed schemas can be)
robbielamb-wf Jan 27, 2022
c92be8f
Merge pull request #111 from Workiva/rl/implement_unevaluatedproperties
michaelcarter-wf Jan 27, 2022
101da4a
Merge branch 'master' of github.com:Workiva/json_schema into remove_d…
michaelcarter-wf Jan 27, 2022
07392a8
fix(package): remove args dep, downgrade path
michaelcarter-wf Jan 27, 2022
2047f3b
Update lib/src/json_schema/validator.dart
tomdeering-wf Jan 27, 2022
547b6e9
Update test/unit/json_schema/nested_refs_in_root_schema_test.dart
tomdeering-wf Jan 27, 2022
5d99a1d
Update test/unit/json_schema/nested_refs_in_root_schema_test.dart
tomdeering-wf Jan 27, 2022
92c4614
Update lib/src/json_schema/validator.dart
tomdeering-wf Jan 27, 2022
0860454
Make ValidationResults.errors final
tomdeering-wf Jan 27, 2022
9c6fa78
Merge branch 'td/validateWithResults' of github.com:Workiva/json_sche…
tomdeering-wf Jan 27, 2022
9f4b7c6
Merge remote-tracking branch 'origin/support_2019_09' into rl/fixup-refs
robbielamb-wf Jan 27, 2022
5522610
make format
tomdeering-wf Jan 27, 2022
f872141
Format again with Dart 2.15.1
tomdeering-wf Jan 27, 2022
d9fc779
Merge pull request #119 from Workiva/td/validateWithResults
rmconsole5-wk Jan 27, 2022
f0a555c
json_schema_3.2.0
rmconsole-readonly-wk Jan 27, 2022
9baa197
Move test folder from 'custom_tests' to 'custom'
robbielamb-wf Jan 27, 2022
9a33991
doc(CHANGELOG): update CHANGELOG
michaelcarter-wf Jan 27, 2022
eacc119
Merge pull request #122 from Workiva/release_json_schema_3.2.0
rmconsole6-wk Jan 27, 2022
319e751
Merge pull request #115 from Workiva/rl/easy_tests
michaelcarter-wf Jan 27, 2022
d0c3d84
Merge remote-tracking branch 'origin/master' into support_2019_09
tomdeering-wf Jan 27, 2022
58cc89b
Merge branch 'support_2019_09' of github.com:Workiva/json_schema into…
tomdeering-wf Jan 27, 2022
bd6d626
Merge branch 'support_2019_09' of github.com:Workiva/json_schema into…
michaelcarter-wf Jan 27, 2022
37c96b6
Merge branch 'master' of github.com:Workiva/json_schema into remove_d…
michaelcarter-wf Jan 27, 2022
18de6ad
Merge remote-tracking branch 'origin/support_2019_09' into rl/fixup-refs
robbielamb-wf Jan 27, 2022
ced8111
imp(validate): replace validateWithErrors with validate
michaelcarter-wf Jan 27, 2022
d3b76ff
doc(package): author CHANGELOG and MIRGRATION guide for 4.0
michaelcarter-wf Jan 27, 2022
f6d32fd
doc(package): nits
michaelcarter-wf Jan 27, 2022
7d76e3a
doc(license): update license year
michaelcarter-wf Jan 27, 2022
852c0bd
Merge pull request #120 from Workiva/remove_deprecated_things
michaelcarter-wf Jan 27, 2022
916957d
Merge remote-tracking branch 'origin/support_2019_09' into rl/fixup-refs
robbielamb-wf Jan 27, 2022
97b3deb
Save old parents, so we can keep them around when we run out of stack…
robbielamb-wf Jan 27, 2022
6455adc
Remove old function.
robbielamb-wf Jan 27, 2022
69e4dca
Merge pull request #112 from Workiva/rl/fixup-refs
tomdeering-wf Jan 27, 2022
792dd99
Merge remote-tracking branch 'origin/support_2019_09' into support_20…
robbielamb-wf Jan 28, 2022
a8f9dde
Run in additional test setups for draft2020
robbielamb-wf Jan 28, 2022
769a7df
Lookup prefixItems for refs
robbielamb-wf Jan 28, 2022
074d528
Make dynamicRefs and dynamicAnchors work.
robbielamb-wf Jan 31, 2022
0b23529
Don't initialize a variable.
robbielamb-wf Jan 31, 2022
a34ffcd
Fix some nits.
robbielamb-wf Jan 31, 2022
85f3027
A failing test example.
robbielamb-wf Jan 31, 2022
87f1ee1
Fixup some variable names.
robbielamb-wf Feb 1, 2022
3c6e517
Allow evaluating properties in referenced schemas when there are
robbielamb-wf Feb 1, 2022
aaafa40
Adjust resolving dynamic anchors methods.
robbielamb-wf Feb 2, 2022
5ce8a62
Merge pull request #124 from Workiva/rl/failing_refs
robbielamb-wf Feb 2, 2022
91fde8e
Merge branch 'support_2019_09' into support_2020_12
robbielamb-wf Feb 2, 2022
179f517
Merge branch 'support_2020_12' into rl/rework_refs
robbielamb-wf Feb 2, 2022
506c1b1
Change optional positional parmater into a named parameter.
robbielamb-wf Feb 2, 2022
61a1f2f
Merge pull request #123 from Workiva/rl/rework_refs
michaelcarter-wf Feb 2, 2022
cd9df3b
Break the draft2019 accessor map into it's corresponding vocabularies.
robbielamb-wf Feb 2, 2022
e3bc716
Break the draft2020 accessor map into the corresponding vocabularies.
robbielamb-wf Feb 3, 2022
8d0fd95
Removing vocab checks from the validator.
robbielamb-wf Feb 7, 2022
220e85e
Select the meta-schema vocabulary early in the process.
robbielamb-wf Feb 7, 2022
d20366b
Cleaning up some small items.
robbielamb-wf Feb 8, 2022
d36cf9f
Clean up some vocabulary selection.
robbielamb-wf Feb 8, 2022
3cd496e
Clean up some formatting and comments.
robbielamb-wf Feb 9, 2022
626a88d
Change function signatures to use Object instead of dynamic.
robbielamb-wf Feb 9, 2022
1299637
First pass at registering and validating custom vocabularies.
robbielamb-wf Feb 10, 2022
0d60baa
Merge pull request #125 from Workiva/rl/vocabulary_support
michaelcarter-wf Feb 11, 2022
0bb9b42
Some cleanup and documentation.
robbielamb-wf Feb 11, 2022
285e9e8
CustomVocabulary example.
robbielamb-wf Feb 11, 2022
482bffc
Add Copyright headers
robbielamb-wf Feb 11, 2022
f62edf9
Change up error message.
robbielamb-wf Feb 11, 2022
75dae00
Add in a Deprecated message.
robbielamb-wf Feb 14, 2022
ba39033
Additional comment. Set the initial custom validation state to null. …
robbielamb-wf Feb 14, 2022
007b708
Fixing a test with futures.
robbielamb-wf Feb 14, 2022
f9fef99
Fix up the other error.
robbielamb-wf Feb 14, 2022
868b625
Formatting
robbielamb-wf Feb 14, 2022
d1766ab
Backport a hashing function from a newer dart.
robbielamb-wf Feb 15, 2022
b0382ba
Move hasher functions into a utility file.
robbielamb-wf Feb 15, 2022
277e2ff
Use Map.from() in JsonSchema._fromRootMap
markerickson-wf Feb 15, 2022
c2afe1c
Make some changes so we can load baked in schemas from disk.
robbielamb-wf Feb 15, 2022
368d813
Also use Map.from() in JsonSchema._fromMap
markerickson-wf Feb 15, 2022
c062cea
test use Map.from() in JsonSchema._fromMap
markerickson-wf Feb 15, 2022
25d46d5
Update lib/src/json_schema/schema_url_client/html_schema_url_client.dart
robbielamb-wf Feb 15, 2022
52eb56a
Update lib/src/json_schema/json_schema.dart
robbielamb-wf Feb 15, 2022
b7bb6ac
Update lib/src/json_schema/schema_url_client/io_schema_url_client.dart
robbielamb-wf Feb 15, 2022
a80d198
Update lib/src/json_schema/json_schema.dart
robbielamb-wf Feb 15, 2022
700cf04
Update lib/src/json_schema/custom_vocabularies.dart
robbielamb-wf Feb 15, 2022
0f7bb1a
Clean up naming and some getters.
robbielamb-wf Feb 15, 2022
dffac59
Merge pull request #127 from Workiva/rl/custom_hasher
michaelcarter-wf Feb 16, 2022
c128a46
Merge pull request #129 from Workiva/rl/load_local_schemas_from_disk
michaelcarter-wf Feb 16, 2022
164cd0b
Throw error on null schemaMap. Test Map.unmodifiable.
markerickson-wf Feb 16, 2022
2ab2a8f
Change from a validation result to a validation context.
robbielamb-wf Feb 16, 2022
a2ed677
Clean up analysis issues.
robbielamb-wf Feb 16, 2022
cdc7716
Merge remote-tracking branch 'origin/support_2020_12' into rl/custom_…
robbielamb-wf Feb 16, 2022
f6a7199
Merge pull request #128 from Workiva/create-using-map-from
rmconsole2-wf Feb 16, 2022
358aa7e
Merge pull request #126 from Workiva/rl/custom_vocab
michaelcarter-wf Feb 17, 2022
c125b96
Initial try at fixing up resolving schemas at a path
robbielamb-wf Feb 21, 2022
aff6912
json_schema_3.2.1
rmconsole-readonly-wk Feb 22, 2022
be94dd4
Merge pull request #132 from Workiva/release_json_schema_3.2.1
rmconsole4-wk Feb 22, 2022
8441a7b
A simpler check.
robbielamb-wf Feb 22, 2022
537406f
Make cases where we want to continue explicit and document them.
robbielamb-wf Feb 22, 2022
6df7984
Add some new tests
robbielamb-wf Feb 23, 2022
45ab7e3
Ignore some property types when traversing paths.
robbielamb-wf Feb 23, 2022
432cb39
WIP
robbielamb-wf Feb 24, 2022
168d652
Throw an exception when there is an ambigious path
robbielamb-wf Feb 24, 2022
c1d6f2f
Adjusting the tests.
robbielamb-wf Feb 28, 2022
d3763f3
Another check point.
robbielamb-wf Feb 24, 2022
1e55222
Merge branch 'rl/fixup_schema_references' into rl/more_pathing
robbielamb-wf Feb 28, 2022
c45f445
Merge pull request #131 from Workiva/rl/fixup_schema_references
michaelcarter-wf Feb 28, 2022
3a9fa45
Merge remote-tracking branch 'origin/master' into support_2020_12
robbielamb-wf Feb 28, 2022
a0f5cb1
Cleaning up some code mess.
robbielamb-wf Feb 28, 2022
9c9fb87
More massaging of code.
robbielamb-wf Feb 28, 2022
29e6bc3
Move memomization into the root schema object.
robbielamb-wf Feb 28, 2022
3344271
Merge remote-tracking branch 'origin/support_2020_12' into rl/more_pa…
robbielamb-wf Feb 28, 2022
3e96341
Merge pull request #118 from Workiva/support_2020_12
rmconsole4-wk Feb 28, 2022
b12b347
Fixing analysis errors.
robbielamb-wf Feb 28, 2022
5bba882
Merge pull request #134 from Workiva/rl/more_pathing
rmconsole7-wk Mar 1, 2022
8cd89a3
feat(package): add support for custom formats
michaelcarter-wf Mar 2, 2022
fad7d51
imp(package): reorganize directories
michaelcarter-wf Mar 2, 2022
07ab96a
doc(package): update changelog
michaelcarter-wf Mar 2, 2022
f4a3dc5
test(custom-formats): basic test for custom formats
michaelcarter-wf Mar 2, 2022
f23ddc7
imp(package): update changelog and migration guide, add tests
michaelcarter-wf Mar 2, 2022
ec739c7
chore(package): format with 2.15
michaelcarter-wf Mar 2, 2022
b96dd0d
fix(hostname-validator): change minimum version conditional
michaelcarter-wf Mar 3, 2022
ede2afc
Merge pull request #135 from Workiva/default_validator_improvements
rmconsole6-wk Mar 3, 2022
2fba036
json_schema_4.0.0-rc.2
rmconsole-readonly-wk Mar 3, 2022
451a1f1
Merge pull request #136 from Workiva/release_json_schema_4.0.0-rc.2
rm-astro-wf Mar 3, 2022
027a7b0
json_schema_4.0.0
rmconsole-readonly-wk Mar 4, 2022
29103b6
chore(package): fix rosie's error
michaelcarter-wf Mar 4, 2022
f963f73
Merge pull request #138 from Workiva/release_json_schema_4.0.0
rmconsole2-wf Mar 4, 2022
61b51ee
imp(json-schema): memoize hashCode and make schemaMap immutable
michaelcarter-wf Mar 4, 2022
1a569f0
fix(package): remove extra file
michaelcarter-wf Mar 4, 2022
de564cf
fix(validator): memoize IRP hashcode and no toLists
michaelcarter-wf Mar 4, 2022
c138e45
chore(package): format
michaelcarter-wf Mar 4, 2022
4888b00
fix(package): move some models to separate files, fix tests
michaelcarter-wf Mar 7, 2022
394eab4
chore(package): rework imports
michaelcarter-wf Mar 7, 2022
6f29a2f
fix(validator): extra checks around adding things to to evaluated con…
michaelcarter-wf Mar 7, 2022
7fbfa2d
fix(validator): don't evaluate all schemas in anyOf if one passes
michaelcarter-wf Mar 7, 2022
b5d8060
Merge pull request #139 from Workiva/resolve_ref_perf
rmconsole2-wf Mar 7, 2022
cc830fc
json_schema_4.0.1
rmconsole-readonly-wk Mar 7, 2022
bbe60aa
doc(package): update changelog for 4.0.1
michaelcarter-wf Mar 7, 2022
709faf4
Merge pull request #140 from Workiva/release_json_schema_4.0.1
rmconsole4-wk Mar 7, 2022
1f1fc1f
TASKPLAT-1105: support null typeList in type getter
joshriesenbach-wk Mar 17, 2022
62878bc
Merge pull request #141 from Workiva/TASKPLAT-1105
rmconsole5-wk Mar 17, 2022
6130e4a
json_schema_4.0.2
rmconsole-readonly-wk Mar 17, 2022
4a7c272
Merge pull request #142 from Workiva/release_json_schema_4.0.2
rmconsole6-wk Mar 17, 2022
d57f607
chore: update dependencies
JKRhb Mar 23, 2022
35c7d35
refactor: update to sound null safety
JKRhb Mar 25, 2022
205e298
Replace deprecated commands with new dart commands
robbecker-wf Apr 22, 2022
8fbb4a0
Try removing usages of .slice to work around a dart2js compiler bug
greglittlefield-wf May 27, 2022
e43a07f
Format
greglittlefield-wf May 27, 2022
08dc1e0
Fix indices to get unit tests to pass. I don't actually understand wh…
tonybathgate-wk Jun 2, 2022
12bd23a
remove unnecessary sublist call
tonybathgate-wk Jun 2, 2022
e518595
revert a format change? idk why my dart format command works differently
tonybathgate-wk Jun 2, 2022
d82ad1e
Merge pull request #144 from Workiva/batch/fea/dart_commands
rmconsole4-wk Jun 3, 2022
79d1318
update comment to match List type
tonybathgate-wk Jun 3, 2022
80b3ce8
Merge pull request #145 from Workiva/no-slice
rm-astro-wf Jun 3, 2022
ab2aa18
json_schema_4.0.3
rmconsole-readonly-wk Jun 6, 2022
ca97268
Add 4.0.2 and 4.0.3 changelog
greglittlefield-wf Jun 6, 2022
f79e572
Merge pull request #146 from Workiva/release_json_schema_4.0.3
rmconsole6-wk Jun 7, 2022
264a226
Merge branch 'master' into update-dependencies
JKRhb Jan 27, 2023
dec287c
Update dart dependencies
Apr 18, 2023
712b113
Merge pull request #148 from Workiva/batch/fedx/update_deps_april_23
rmconsole2-wf Apr 19, 2023
f9b4c4a
remove dart 3 from CI for now
robbecker-wf Apr 19, 2023
b0e7d4e
jsut use stable
robbecker-wf Apr 19, 2023
13d7d61
Update dependencies to get to newer test pkg
robbecker-wf Apr 19, 2023
17281b8
Merge pull request #150 from Workiva/remove_dart_3_ci_matrix_until_nu…
rmconsole6-wk Apr 19, 2023
04ffbf0
json_schema_4.0.4
rmconsole-readonly-wk Apr 19, 2023
290f17b
Merge pull request #151 from Workiva/release_json_schema_4.0.4
rmconsole7-wk Apr 19, 2023
09cb9b7
Merge branch 'master' into update-dependencies
JKRhb May 19, 2023
d6bdc50
Re-format json_schema.dart
JKRhb May 19, 2023
0aa56de
Remove unnecessary null comparison
JKRhb May 19, 2023
f7b476a
Merge pull request #143 from namib-project/update-dependencies
michaelcarter-wf May 19, 2023
73b50f0
json_schema_5.0.0-rc1
rmconsole-readonly-wk May 19, 2023
efa02ae
Merge pull request #152 from Workiva/release_json_schema_5.0.0-rc1
rmconsole2-wf May 19, 2023
75a53a8
Updated changelog for version 5.0.0-rc1.
kyleferguson-wk May 19, 2023
5d50e32
CUI-1729: drop rc1 from changelog entry.
kyleferguson-wk May 19, 2023
6c32615
Merge pull request #154 from Workiva/CUI-1729
rmconsole3-wf May 19, 2023
5035e68
json_schema_5.0.0-rc2
rmconsole-readonly-wk May 22, 2023
5b703b5
Update new version to be the correct one.
kyleferguson-wk May 22, 2023
c6add5a
Merge pull request #155 from Workiva/release_json_schema_5.0.0-rc2
rmconsole3-wf May 22, 2023
b66d7e4
json_schema_5.0.0
rmconsole-readonly-wk May 27, 2023
aec0025
Update pubspec.yaml
robbecker-wf May 27, 2023
f5136da
Merge pull request #157 from Workiva/release_json_schema_5.0.0
rm-astro-wf May 30, 2023
1196ca3
Minor cleanup
robbecker-wf May 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
183 changes: 183 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,183 @@
# Contributing to json_schema

Looking to contribute something to the json_schema library? __Here's how you can help.__

+ __[Coding Standards](#coding-standards)__
+ [General Formatting Guidelines](#general-formatting-guidelines)
+ __[Using the Issue Tracker](#using-the-issue-tracker)__
+ [Reporting Bugs](#bug-reports)
+ [Feature Requests](#feature-requests)
+ [Submitting Pull Requests](#pull-requests)
+ __[Developer Workflow](#developer-workflow)__




## Coding standards

A lot can be gained by writing code in a consistent way. Moreover, always remember that code is written and
maintained by _people_. Ensure your code is descriptive, well commented, and approachable by others.

__ALWAYS__ adhere to the [Dart Style Guide]. _Please take the time to read it if you have never done so._

 


### General formatting guidelines

+ __AVOID__ lines longer than 120 characters.
+ __AVOID__ using `dart format` as an excuse to ignore good judgement about
whether your code is readable and approachable by others.

 
 



## Using the issue tracker

The issue tracker is the preferred channel for [bug reports](#bug-reports) and [feature requests](#feature-requests),
but __please follow the guidelines:__

+ __Fill out the template we've provided.__

+ __Be Professional__
+ Please __do not__ derail or troll issues. Keep the discussion on topic and respect the opinions of others.

+ __Not that Professional__
+ Feel free to include _relevant_ animated gifs to drive home your message / request.

 


### Bug reports

A bug is a _demonstrable problem_ that is caused by the code in the repository.

_Good bug reports are extremely helpful - thank you!__

__Guidelines for bug reports:__

1. __Search for existing issues.__ Duplicate issues can become cumbersome, and you'd help us out a lot by first
checking if someone else has reported the same issue. Moreover, the issue may have already been resolved with a
fix available.

2. __Record a screencast of yourself reproducing the issue__.
1. Be sure the problem exists in json_schema's code by building a
reduced test case that one of the reviewers can pull locally
and test out.

3. __Share as much information as possible.__ Include operating system and version, browser and version, etc. where appropriate.

Always include steps to reproduce the bug.

__Example Bug Report:__

> Short and descriptive example bug report title
>
> A summary of the issue and the browser/OS environment in which it occurs. If
> suitable, include the steps required to reproduce the bug.
>
> 1. This is the first step
> 2. This is the second step
> 3. Further steps, etc.
>
> `<url>` - a link to branch with the reduced test case
>
> Any other information you want to share that is relevant to the issue being
> reported. This might include the lines of code that you have identified as
> causing the bug, and potential solutions (and your opinions on their
> merits).

&nbsp;


### Feature requests

Feature requests are welcome. But take a moment to find out whether your idea fits with the scope and aims of the
project. It's up to *you* to make a strong case to convince the `json_schema` team of the merits of this feature.
Please provide as much detail and context as possible.

&nbsp;


### Pull requests

Good pull requests - patches, improvements, new features - are a fantastic help. They should remain focused in scope
and avoid containing unrelated commits.

__Please ask first__ before embarking on any significant pull request (e.g. implementing features, refactoring code,
porting to a different language), otherwise you risk spending a lot of time working on something that the project's
lead developers might not want to merge into the project.

Please adhere to the [Dart Style Guide] for all changes contained in your pull requests.

Adhering to the following process is the best way to get your work included in the project:

1. [Fork](http://help.github.com/fork-a-repo/) the project, clone your fork,
and configure the remotes:

```bash
# Navigate to the directory where you store repos locally
cd ~/your-local-git-repo-spot
# Clone your fork of the repo into the current directory
git clone git@github.com:<your-username>/json_schema
# Navigate to the newly cloned directory
cd ~/your-local-git-repo-spot/json_schema
# Assign the repo you forked from to a remote called "upstream"
git remote add upstream git@github.com:Workiva/json_schema
```

2. If you cloned a while ago, get the latest changes from upstream:

```bash
git checkout master
git pull upstream master
```

3. Create a new topic branch that will contain your feature, change, or fix:

```bash
git checkout -b <topic-branch-name>
```

4. Commit your changes in logical chunks. Please adhere to these
[git commit message guidelines](#git-commit-message-standards) or your code is unlikely be merged into the master
branch. Optionally, you can use Git's [interactive rebase](https://help.github.com/articles/interactive-rebase)
feature to tidy up your commits before making them public.

5. Write tests for your changes.
1. There are no exceptions.
2. If you're having trouble, reach out in your PR about how to best go about testing your changes.

6. If you have merge conflicts, locally merge the upstream master branch into your topic branch:

```bash
git pull upstream master
```

7. Push your topic branch up to your fork:

```bash
git push origin <topic-branch-name>
```

8. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
with a clear title and description - following all the [issue guidelines](#using-the-issue-tracker) listed above.

&nbsp;
&nbsp;


## Developer Workflow

The `json_schema` developer workflow couldn't be any more simple!

When you're ready to run the tests... run:

```bash
dart run dart_dev test
```


[Dart Style Guide]: https://www.dartlang.org/guides/language/effective-dart/style
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<!--- Provide a general summary of the issue in the title above -->

<!--- Provide the type of issue (Bug, Improvement, Feature Request) -->
## Type

## Details
<!--- If you're describing a bug, tell us what happens instead of the expected behavior -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->

## Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->

<!--- Delete the following sections if not submitting a bug -->

## Steps to Reproduce
<!--- Provide steps to reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.

## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version:
* Browser name / VM and version:
* Operating System and version:

> __FYI:__ @michaelcarter-wf
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## Ultimate problem:


## How it was fixed:


## Testing suggestions:


## Potential areas of regression:



---

> __FYA:__ @michaelcarter-wf
35 changes: 35 additions & 0 deletions .github/workflows/dart_ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Dart CI

on:
push:
branches:
- 'master'
- 'test_consume_*'
pull_request:
branches:
- '*'

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
sdk: [ 2.18.7, stable ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v1
with:
sdk: ${{ matrix.sdk }}
- name: Install dependencies
run: dart pub get
- name: Validate dependencies
run: dart run dependency_validator
- name: Check formatting
run: dart format --line-length=120 --output=none --set-exit-if-changed .
if: ${{ matrix.sdk == 'stable' }}
- name: Analyze project source
run: dart analyze
- name: Check Generated Fixtures Are Up-To-Date
run: make gen-fixtures --check
- name: Run tests
run: make test-with-serve-remotes
14 changes: 7 additions & 7 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
*.~*~
.idea/
.packages
packages
build/
.pub/
.project
.dart_tool/
*.dart.js
*.iml
*.ipr
*.iws
.idea/
*.dart.js
*.js_
*.js.deps
*.js.map
# custom <additional>
build/
coverage
pubspec.lock
# end <additional>

.tool-versions
asdf-dart.uUid
5 changes: 5 additions & 0 deletions .pubignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
test
tool
Makefile
Dockerfile
dart_test.yaml
6 changes: 0 additions & 6 deletions .travis.yml

This file was deleted.

Loading