DRC-7: Add missed appointments report as initial work for Treatment interruptions and loss of follow-up#8
Open
DRC-7: Add missed appointments report as initial work for Treatment interruptions and loss of follow-up#8
Conversation
…nterruptions and loss of follow-up
ibacher
requested changes
May 19, 2025
|
|
||
| @Override | ||
| public String getName() { | ||
| return "Missed Appointments Report"; |
Contributor
There was a problem hiding this comment.
Shouldn't these return the translatable strings (as in MessageUtil.translate(...))?
| JOIN obs o ON p.patient_id = o.person_id | ||
| JOIN person per ON p.patient_id = per.person_id | ||
| JOIN person_name pn ON per.person_id = pn.person_id | ||
| WHERE o.concept_id = 211 |
Contributor
There was a problem hiding this comment.
Because of the way metadata is loaded, it is not safe to rely on concept_ids being consistent across instances of the same system.
Contributor
There was a problem hiding this comment.
Things I'm not quite clear how this report handles:
- Isn't there potentially some duplication between the "Next Appointment Date" and actual schedule appointments? How do we deduplicate those?
- Isn't this just a list of appointments? I.e., I don't see how this filters out appointments that have been attended (I wouldn't expect that this is done via voiding an appointment).
- How do we filter patients who have either died or have transferred out of care?
reagan-meant
requested changes
May 19, 2025
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "Missed Appointments Report"; |
Contributor
There was a problem hiding this comment.
We do the translation here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.