Support for empty Firewall Inbound Rule #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry @bmoers , but I hadn't seen this PR long time ago (in December probably I was celebrating and I didn't pay attention to the mail, sorry). First of all, thanks for your PR, but I'm trying to update the version of the project to node18 because of #32, could you take a look and tell me know if it makes sense to converge both PRs (yours and #33). I'm having some trouble with the dependencies during the upgrading, so maybe worth to put the efforts together. Thanks! |
jorgemaroto-eb
approved these changes
Dec 31, 2023
|
Thanks @bmoers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports adding and removing rules to empty firewalls (currently the action fails if the FW has no inbound rules)