MASTER:: NOTICKET :: Allow control of the faker seed results #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this. As hard as this might be to believe, my colleague and I just sat down to branch PL Faker to include this exact feature. We are already running from a branch (see Issue 2), but hopefully the owner of this repo can get around to merge our changes back to master. |
|
@chaunceyt would you mind rerolling this patch, please? it doesnt apply when using https://github.com/cweagans/composer-patches, as I think someone added some code on the master branch right after you and it conflicts (even thought GitHub says that it does not). |
nerfchicken
added a commit
to nerfchicken/plugin-php-faker
that referenced
this pull request
Feb 5, 2019
Since these 2 pull requests haven't been accepted, I forked the project: pattern-lab#7 pattern-lab#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.