Angular 1.x directive to Angular 1.5 component conversion guide #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenBW
reviewed
Dec 9, 2016
There was a problem hiding this comment.
I wanta just throw this out there as an idea, rather than targeting 1.5, perhaps a target 1.6 is a better idea given that the component inner workings are still fairly fluid.
In 1.6 the the lifecycle hook $onInit becomes the exclusive provider of all models available on the component template. This turns the controller into a bin for functions rather than a 🍜
for more reading: https://toddmotto.com/angular-1-6-is-here
overall though SUPER excited for this change 🌮
| <!-------------> | ||
| <!-- becomes --> | ||
| <!-------------> | ||
| angular.module('patternfly.notification').directive('pfNotificationDrawer', { |
There was a problem hiding this comment.
should this be .component rather than .directive?
|
Nice @dgutride , LGTM |
dtaylor113
approved these changes
Dec 9, 2016
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describes how to convert an Angular 1.x style directive to a new 1.5 style component