fix(button)!: remove shadow <button>

Closes #2706
patternfly · Mar 19, 2024 · 3d04aaa · 3d04aaa
1 parent 53aae9a
commit 3d04aaa
Show file tree

Hide file tree

Showing 7 changed files with 549 additions and 470 deletions.
diff --git a/.changeset/curly-wings-cross.md b/.changeset/curly-wings-cross.md
@@ -0,0 +1,4 @@
+---
+"@patternfly/elements": major
+---
+`<pf-button>`: improves accessibility of elements that use `<pf-button>` by giving the custom element itself the `button` role
diff --git a/elements/pf-button/pf-button-base.css b/elements/pf-button/pf-button-base.css
diff --git a/elements/pf-button/pf-button-icon.css b/elements/pf-button/pf-button-icon.css
@@ -4,7 +4,7 @@
  *                            *
  ******************************/
 
-.pf-button.hasIcon {
+.hasIcon {
   gap: calc(2 * var(--pf-c-button__icon--m-start--MarginLeft,
     var(--pf-global--spacer--xs, 0.25rem)));
 }

diff --git a/elements/pf-button/pf-button-plain.css b/elements/pf-button/pf-button-plain.css
diff --git a/elements/pf-button/pf-button-tokens.css b/elements/pf-button/pf-button-tokens.css
@@ -167,4 +167,7 @@
 	--pf-c-button--disabled__c-badge--BackgroundColor: var(--pf-global--BackgroundColor--200, #f0f0f0);
 	--pf-c-button--m-primary__c-badge--BorderColor: var(--pf-global--BorderColor--300, #f0f0f0);
 	--pf-c-button--m-primary__c-badge--BorderWidth: var(--pf-global--BorderWidth--sm, 1px);
+
+  --_button-color: var(--pf-c-button--m-primary--Color);
+  --_button-background-color: var(--pf-c-button--m-primary--BackgroundColor);
 }