Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<pf-button> must implement it's own button semantics #2706

Closed
bennypowers opened this issue Mar 14, 2024 · 0 comments
Closed

<pf-button> must implement it's own button semantics #2706

bennypowers opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
accessibility Improve accessibility priority: high Severity level: 1

Comments

@bennypowers
Copy link
Member

Component name: <pf-button>

Whereas

  • pf-button uses <button> in it's shadow root
  • and we don't have anything like semantic delegate or cross-root aria yet
  • and we have unavoidable requirements for pf-button's host element to adopt button semantics (case: dropdown with custom button)

Therefore

In consultation with @nikkimk, we've resolved to remove the shadow <button> from pf-button and reimplement it's semantics until the browser vendors ship x-root aria

@bennypowers bennypowers added accessibility Improve accessibility priority: high Severity level: 1 labels Mar 14, 2024
@bennypowers bennypowers self-assigned this Mar 14, 2024
bennypowers added a commit that referenced this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improve accessibility priority: high Severity level: 1
Projects
None yet
Development

No branches or pull requests

1 participant