style(card): 🎨 fixing img with overflow "top" not getting correct top padding #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… padding Adding padding-top to img tag when the element has a header and a slotted image with an overflow of top. Padding-top will be set to pfe-local(spacing);
🦋 Changeset detectedLatest commit: 9caed6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
FYI, the https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type |
bennypowers
reviewed
May 1, 2022
|
Padding looks good to me! |
Adding css for the pfe-card when the image overflow is set to top and the card has a header present.
|
Added the changeset @bennypowers |
bennypowers
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding padding-top to img tag when the element has a header and a slotted image with an overflow of top. Padding-top will be set to pfe-local(spacing);
Padding in imaged card demo not correct for images with overflow="top"
Related issues
What has changed and why
Added css to the pfe-card.scss
Testing instructions
Update can be viewed in the pfe-card demo page.