Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): testing aria-busy to fix lighthouse issue #2694

Closed
wants to merge 1 commit into from
Closed

fix(tabs): testing aria-busy to fix lighthouse issue #2694

wants to merge 1 commit into from

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented Feb 13, 2024

What I did

  1. Testing aria-busy as a solution.

Testing Instructions

Notes to Reviewers

  1. N/A - DO NOT REVIEW.

@nikkimk nikkimk linked an issue Feb 13, 2024 that may be closed by this pull request
<pf-tabs>: roles not being read #2692
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: ceda748

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review functionality Functionality, typically pertaining to the JavaScript. labels Feb 13, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit d83e815
😎 Deploy Preview https://deploy-preview-2694--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 13, 2024
@nikkimk nikkimk closed this Feb 13, 2024
@nikkimk nikkimk deleted the bug/tabs-roles branch February 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. work in progress POC / Not ready for review
Projects
Workflow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<pf-tabs>: roles not being read
1 participant
@nikkimk