Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(button): custom roles #2806

Merged
merged 8 commits into from
Jul 9, 2024
Merged

docs(button): custom roles #2806

merged 8 commits into from
Jul 9, 2024

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Jul 9, 2024

Closes #2805

What I did

  1. document how to apply custom roles to <pf-button>

Testing Instructions

  1. use browser a11y tools to audit the dp demo

Notes to reviewers

Don't merge this into chore/lint-ts-55. Instead, after that merges, change the target of this pr to staging/4.0 and merge into there.

massive lint. no more warnings
enable `isolatedDeclarations`, which makes our dx a bit worse but
improves downstream performance
@bennypowers bennypowers requested a review from kelsS July 9, 2024 08:25
Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: f777fe2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review demo Updating demo pages labels Jul 9, 2024
@github-actions github-actions bot added the AT passed Automated testing has passed label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e15025e
😎 Deploy Preview https://deploy-preview-2806--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

SSR Test Run for a6cd6c8: Report

Copy link
Contributor

github-actions bot commented Jul 9, 2024

SSR Test Run for cbb6f71: Report

Base automatically changed from chore/lint-ts-55 to staging/4.0 July 9, 2024 14:27
@bennypowers bennypowers marked this pull request as ready for review July 9, 2024 14:28
Copy link
Contributor

github-actions bot commented Jul 9, 2024

SSR Test Run for e8c89e3: Report

Copy link
Contributor

github-actions bot commented Jul 9, 2024

SSR Test Run for e15025e: Report

@kelsS
Copy link
Contributor

kelsS commented Jul 9, 2024

@bennypowers this looks good to me and makes sense, however I only want to use the custom role for the carousel slider buttons temporarily. Ultimately I would like to help get a carousel slider component itself into the design system. I posted more comments and asked for your thoughts in our Slack thread. I look forward to hearing from you!

@kelsS kelsS merged commit d7459d7 into staging/4.0 Jul 9, 2024
12 of 13 checks passed
@kelsS kelsS deleted the docs/button/custom-roles branch July 9, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed demo Updating demo pages work in progress POC / Not ready for review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants