-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(button): custom roles #2806
Conversation
massive lint. no more warnings
enable `isolatedDeclarations`, which makes our dx a bit worse but improves downstream performance
|
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@bennypowers this looks good to me and makes sense, however I only want to use the custom role for the carousel slider buttons temporarily. Ultimately I would like to help get a carousel slider component itself into the design system. I posted more comments and asked for your thoughts in our Slack thread. I look forward to hearing from you! |
Closes #2805
What I did
<pf-button>
Testing Instructions
Notes to reviewers
Don't merge this into chore/lint-ts-55. Instead, after that merges, change the target of this pr to staging/4.0 and merge into there.