-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(upgrade): Adds missing details. #4479
Conversation
made a variety of changes to try and cover all open requests/issues related to this. if I missed anything please lmk!
and then cc @nicolethoen in general, per the things you suggested from your upgrade experiences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an excellent iterative improvement! 🥇
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update overall!
Regarding the css-vars-updater (#4446) I think the section is perfectly fine as the details are explained under the Run tokens-update
section above + there is always a link to README.
I am not sure whether some of the Notable changes
require that much manual attention (but I may be wrong, cc @nicolethoen) so I left some comments.
Also the Update React tokens
section should be updated - left a comment there.
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🎉
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just on little update neeeded
Closes #4459